New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Release bundles #466
Changes from 2 commits
3d190ec
a28d9eb
f115b40
f42625b
fe05c46
06eae54
d0588f8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,6 +168,16 @@ void getAll( | |
@Nonnull | ||
WriteBatch batch(); | ||
|
||
/** | ||
* Returns a FirestoreBundle.Builder {@link FirestoreBundle.Builder} instance for the given bundle | ||
* Id. | ||
* | ||
* @param bundleId If null, an random string will be used for the Id. The Id is used by the client | ||
* SDKs loading bundles to identify if a bundle has been loaded before. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/Id/ID and swap both sentences. If a null bundle ID is how me mainly expect the bundles to be used, should we add an overload that doesn't require an explicit There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, that is better. I also realized we provided no way for the client to get the bundle id if it is auto-id, they probably want to use it to manage their bundle serving. I added a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thought on adding |
||
*/ | ||
@Nonnull | ||
FirestoreBundle.Builder bundleBuilder(@Nullable String bundleId); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/ |
||
|
||
/** | ||
* Closes the gRPC channels associated with this instance and frees up their resources. This | ||
* method blocks until all channels are closed. Once this method is called, this Firestore client | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Id/ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.