Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add BulkWriter #323

Merged
merged 8 commits into from Aug 11, 2020
Merged

feat: add BulkWriter #323

merged 8 commits into from Aug 11, 2020

Commits on Aug 7, 2020

  1. fix: add bulkCommit() (#231)

    @BenWhitehead
    Brian Chen authored and BenWhitehead committed Aug 7, 2020
    Copy the full SHA
    2b1e063 View commit details
    Browse the repository at this point in the history

  2. fix: Add BulkWriter (#233)

    @BenWhitehead
    Brian Chen authored and BenWhitehead committed Aug 7, 2020
    Copy the full SHA
    db07700 View commit details
    Browse the repository at this point in the history

  3. fix: use sentinel on BulkWriter.delete() (#251)

    @BenWhitehead
    Brian Chen authored and BenWhitehead committed Aug 7, 2020
    Copy the full SHA
    7271a1e View commit details
    Browse the repository at this point in the history

  4. fix: add BulkWriter system tests + pass BE error messages (#252)

    @BenWhitehead
    Brian Chen authored and BenWhitehead committed Aug 7, 2020
    Copy the full SHA
    3f250bf View commit details
    Browse the repository at this point in the history

  5. fix: add pojo support (#265)

    @BenWhitehead
    Brian Chen authored and BenWhitehead committed Aug 7, 2020
    Copy the full SHA
    115a184 View commit details
    Browse the repository at this point in the history

  6. fix: add retry on ABORTED errors (#286) 

    * fix: add retry on ABORTED errors

* WIP: test pass individually, concurrency error

* WIP: tests passing but hidden concurrency bug

* use BulkCommitBatch constructor, remove completeFuture

* use firestoreExecutor and update rate limiter test

* add todo for successfulAsList

* Update BulkWriterTest to check number of retry attempts

* build: manually bump com.google.api:api-common to v1.10.0

This change should be cleaned up after com.google.com:google-cloud-shared-dependencies v0.8.4 is available

* test: add junit timeout rule to BulkWriterTest (#312)

* update to use successfulAsList

* add test to verify successfulAsList

* lint

* resolve comments, fix concurrency issue?

* resolve comments, add additional test for flush

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
    @BenWhitehead
    Brian Chen and BenWhitehead committed Aug 7, 2020
    Copy the full SHA
    5972c94 View commit details
    Browse the repository at this point in the history

  7. chore: update clirr rules

    @BenWhitehead
    BenWhitehead committed Aug 7, 2020
    Copy the full SHA
    231be2f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. resolve ben comments

    Brian Chen committed Aug 11, 2020
    Copy the full SHA
    305602c View commit details
    Browse the repository at this point in the history