Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ehsann/tracing merge main #1667

Closed
wants to merge 27 commits into from
Closed

Ehsann/tracing merge main #1667

wants to merge 27 commits into from

Commits on Mar 19, 2024

  1. feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions. (#1531)

    * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions.
    
    * Address code review feedback.
    ehsannas committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    9ed185b View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. feat: Add com.google.cloud.firestore.telemetry package. (#1533)

    * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions.
    
    * feat: Add com.google.cloud.firestore.telemetry package.
    
    * Address code review feedback.
    
    * Factor out the otel version in pom.xml.
    ehsannas committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ef6bcb5 View commit details
    Browse the repository at this point in the history
  2. fix: Remove OpenCensus tracing code. (#1589)

    * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions.
    
    * feat: Add com.google.cloud.firestore.telemetry package.
    
    * fix: Remove OpenCensus tracing code.
    ehsannas committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2cf3f5b View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. feat: tracing for aggregate queries, bulkwriter, partition queries, a… (

    #1590)
    
    * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions.
    
    * feat: Add com.google.cloud.firestore.telemetry package.
    
    * fix: Remove OpenCensus tracing code.
    
    * feat: tracing for aggregate queries, bulkwriter, partition queries, and listDocuments.
    
    * Address code review feedback.
    
    * Address feedback.
    
    * don't use wildcard imports.
    ehsannas committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b8533c4 View commit details
    Browse the repository at this point in the history
  2. feat: trace instrumentation for DocumentReference methods. (#1591)

    * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions.
    
    * feat: Add com.google.cloud.firestore.telemetry package.
    
    * fix: Remove OpenCensus tracing code.
    
    * feat: tracing for aggregate queries, bulkwriter, partition queries, and listDocuments.
    
    * feat: trace instrumentation for DocumentReference methods.
    ehsannas committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    cf03252 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. feat: trace instrumentation for queries and transactions. (#1592)

    * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions.
    
    * feat: Add com.google.cloud.firestore.telemetry package.
    
    * fix: Remove OpenCensus tracing code.
    
    * feat: tracing for aggregate queries, bulkwriter, partition queries, and listDocuments.
    
    * feat: trace instrumentation for DocumentReference methods.
    
    * feat: trace instrumentation for queries and transactions.
    
    * test: Adding first e2e client-tracing test w/ Custom Root Span (#1621)
    
    * test: Adding first e2e client-tracing test w/ Custom Root Span
    
    * Roll back E2E tests commit.
    
    * Address feedback.
    
    * Address feedback (better event log message).
    
    * Address feedback.
    
    ---------
    
    Co-authored-by: Jimit J Shah <57637300+jimit-j-shah@users.noreply.github.com>
    ehsannas and jimit-j-shah committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7b8c405 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. test: End-to-End Integration Test for Client-side Tracing in Firestor…

    …e Java Server SDK using OpenTelemetry SDK and Cloud Trace Exporter against Cloud Trace. (#1635)
    
    * Adding first e2e client-tracing test w/ Custom Root Span
    
    * test: Adding first e2e client-tracing test w/ Custom Root Span
    
    * Fixing test dependencies and use default GCP testing project.
    
    Fixing
    
    * Fixing test dependencies and use default GCP testing project.
    
    * Fixing formatting
    
    * Add aggregationQueryGet Test
    
    * Add bulkWriterCommitTrace Test
    
    * Fixing running multiple-tests
    
    * Add partitionQuery Test
    
    * Add collectionListDocumentsTrace Test
    
    * Add docRef*Trace Tests
    
    * Add docRefUpdate*Trace and docRefDelete*Trace Tests
    
    * Fixing Trace fetching using retries for missing or incomplete traces due to eventual consistency of Cloud Trace
    
    * Add get/query Trace Tests
    
    * Add Transaction test
    
    * Added TraceContainer to be able to test transaction test-cases
    
    * test: Adding Transaction tests
    
    * test: Adding Transaction tests
    
    * test: Adding TestParameterInjector to run the test for global and non-global opentelemetry SDK instances
    
    * test: formatting and cleanup
    
    * test: Adding first e2e client-tracing test w/ Custom Root Span
    
    * test: Add aggregationQueryGet Test
    
    * test: Add bulkWriterCommitTrace Test and fixed running multiple-tests
    
    * test: Add partitionQuery Test
    
    * test: Add collectionListDocumentsTrace Test
    
    * test: Add docRefUpdate*Trace and docRefDelete*Trace Tests and fixed Trace fetching using retries for missing or incomplete traces due to eventual consistency of Cloud Trace
    
    * test: Add get/query Trace Tests
    
    * test: Added Transaction tests using TraceContainer to verify traces for Transaction ops (BeginTransaction, Rollback etc)
    
    * test: Adding TestParameterInjector to run the test for global and non-global opentelemetry SDK instances
    
    * test: Formatting and cleanup
    
    * test: review comments
    
    * test: fixing dfs to handle case where the compareTo callstack may be shorter than the trace callstack - don't need to throw an exception in that case
    
    * test: Consolidating verification methods
    
    * test: review comments
    jimit-j-shah committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    84e0101 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    9945414 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. fix: Rename 'enabled' to 'tracingEnabled'. (#1639)

    * fix: Rename 'enabled' to 'tracingEnabled'.
    
    In the future, FirestoreOpenTelemetryOptions will support enabling/disabling
    Logging and Metrics as well. So we should use a better name for this field.
    
    * address feedback.
    ehsannas committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    43d82b1 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Configuration menu
    Copy the full SHA
    735b3e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cc7e7cd View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    9e9a73e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0aa1c0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    274c842 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fa59b9d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    00dc4ea View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1b41f9b View commit details
    Browse the repository at this point in the history
  7. Revert "see if deleting all tests help."

    This reverts commit 1b41f9b.
    ehsannas committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3221bed View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7195c29 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ce684ab View commit details
    Browse the repository at this point in the history
  10. Revert "disable tests for the graalvm ci for proto-google-cloud-fires…

    …tore-v1."
    
    This reverts commit ce684ab.
    ehsannas committed May 2, 2024
    Configuration menu
    Copy the full SHA
    0b4a4da View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    384cf17 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    dfb199b View commit details
    Browse the repository at this point in the history
  2. update pojo class.

    ehsannas committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1268dd1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2a76b5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    53d727b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0f32c62 View commit details
    Browse the repository at this point in the history