feat: Add BulkWriter buffer limit #1606
Conversation
product-auto-label
bot
added
size: m
tom-andersen
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: l
tom-andersen
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
| @@ -167,24 +168,22 @@ enum OperationType { | |||
| private final RateLimiter rateLimiter; | |||
|
|
|||
| /** | |||
| * The number of pending operations enqueued on this BulkWriter instance. An operation is | |||
| * The number of in-flight operations enqueued on this BulkWriter instance. An operation is | |||
| * considered pending if BulkWriter has sent it via RPC and is awaiting the result. | |||
There was a problem hiding this comment.
considered pending if BulkWriter should this be changed to "in-flight" as well?
| @Nullable | ||
| public abstract Integer getMaxPendingOps(); | ||
|
|
||
| abstract int getMaxInFlightOps(); |
There was a problem hiding this comment.
needs a comment here.
BTW, maybe expalin the relationship between pendingOps and InFlightOps
| */ | ||
| private static final int DEFAULT_MAXIMUM_PENDING_OPERATIONS_COUNT = 500; | ||
| static final int DEFAULT_MAXIMUM_IN_FLIGHT_OPERATIONS = 500; |
There was a problem hiding this comment.
why define it here, while it is only used in the "BulkWriterOptions" file
| if (pendingOpsCount < maxPendingOpCount) { | ||
| pendingOpsCount++; | ||
| // Schedule the operation if the BulkWriter has fewer than the maximum number of allowed | ||
| // pending operations, or add the operation to the buffer. |
There was a problem hiding this comment.
"allowed in-flight operations"
| // operation now. This overcomes the small chance that an in-flight operation completes | ||
| // before another operation has been added to buffer. | ||
| if (incrementInFlightCountIfLessThanMax()) { | ||
| if (!processNextBufferedOperation()) { |
There was a problem hiding this comment.
looks strange to do the same condition check twice to see if any operation has been completed during the last condition check.
No description provided.