Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use SecureRandom instead of Random to reduce the chance of auto-id collisions #156

Merged
merged 2 commits into from Mar 27, 2020
Merged

feat: use SecureRandom instead of Random to reduce the chance of auto-id collisions #156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0316066
Use SecureRandom instead of Random to reduce the chance of auto-id co…
dconeybe Mar 27, 2020
d8f74ff
Empty commit to re-trigger presubmits.
dconeybe Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java
View file
Open in desktop
Expand Up @@ -41,6 +41,7 @@
import io.opencensus.trace.Span;
import io.opencensus.trace.Tracer;
import io.opencensus.trace.Tracing;
import java.security.SecureRandom;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
Expand All @@ -57,7 +58,7 @@
*/
class FirestoreImpl implements Firestore {

private static final Random RANDOM = new Random();
private static final Random RANDOM = new SecureRandom();
private static final int AUTO_ID_LENGTH = 20;
private static final String AUTO_ID_ALPHABET =
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
Expand Down