Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add clirr-ignored-differences.xml for new runAsyncTransaction methods added to Firestore #143

Merged
merged 1 commit into from Mar 23, 2020

Conversation

BenWhitehead
Copy link
Collaborator

Fixes the broken build from new methods added in #103

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2020
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #143 into master will increase coverage by 0.05%.
The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #143      +/-   ##
============================================
+ Coverage     71.56%   71.62%   +0.05%     
- Complexity      968      969       +1     
============================================
  Files            62       62              
  Lines          5202     5222      +20     
  Branches        579      579              
============================================
+ Hits           3723     3740      +17     
- Misses         1299     1302       +3     
  Partials        180      180              
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/firestore/Transaction.java 97.77% <ø> (ø) 11.00 <0.00> (ø)
...java/com/google/cloud/firestore/FirestoreImpl.java 82.35% <95.23%> (+0.28%) 24.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3458cb...cfe23ad. Read the comment docs.

@BenWhitehead BenWhitehead merged commit efc138d into googleapis:master Mar 23, 2020
@BenWhitehead BenWhitehead deleted the clirr-rules branch March 23, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants