Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Re-enable test aggregateQueryInATransactionShouldLockTheCountedDocuments #1043

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 22, 2022

The test aggregateQueryInATransactionShouldLockTheCountedDocuments was disabled in #1040 because it failed when running against production.

java.lang.AssertionError: expected java.util.concurrent.ExecutionException to be thrown, but nothing was thrown
	at com.google.cloud.firestore.ITQueryCountTest.aggregateQueryInATransactionShouldLockTheCountedDocuments(ITQueryCountTest.java:238)

I need to check if this is a bug in the backend or a faulty test. This test passes against the Firestore emulator.

Here is the line in the test that is failing:

executionException = assertThrows(ExecutionException.class, documentSetTask::get);

I've opened b/248152832 to investigate.

Once the issue is fixed, merge this PR to re-enable the test.

@dconeybe dconeybe added the api: firestore Issues related to the googleapis/java-firestore API. label Sep 22, 2022
@dconeybe dconeybe self-assigned this Sep 22, 2022
Base automatically changed from dconeybe/EnableITQueryCountTestInCI to main September 23, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant