fix: Made test exception text useful

googleapis · Jan 28, 2021 · 9824050 · 9824050
1 parent aa22a9d
commit 9824050
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/google-cloud-firestore/src/test/java/com/google/cloud/firestore/MapperTest.java b/google-cloud-firestore/src/test/java/com/google/cloud/firestore/MapperTest.java
@@ -20,6 +20,7 @@
 import static com.google.cloud.firestore.LocalFirestoreHelper.mapAnyType;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
@@ -1236,9 +1237,15 @@ public void primitiveDeserializeLong() {
     }
   }
 
-  @Test(expected = RuntimeException.class)
+  @Test
   public void primitiveDeserializeWrongTypeMap() {
-    deserialize("{'value': {'foo': 'bar'}}", StringBean.class);
+    String expectedExceptionMessage =
+        ".* Failed to convert value of type .*Map to String \\(found in field 'value'\\).*";
+    Throwable exception =
+        assertThrows(
+            RuntimeException.class,
+            () -> deserialize("{'value': {'foo': 'bar'}}", StringBean.class));
+    assertTrue(exception.getMessage().matches(expectedExceptionMessage));
   }
 
   @Test
@@ -2517,7 +2524,7 @@ public void settersCanOverridePrimitiveSettersParsing() {
     NonConflictingSetterSubBean bean =
         deserialize("{'value': 2}", NonConflictingSetterSubBean.class);
     // sub-bean converts to negative value
-    assertEquals(-2, bean.value, 0);
+    assertEquals(-2, bean.value);
   }
 
   @Test