Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

fix!: change routing to remove location parameter in preparation for the addition of regional support #178

Merged
merged 3 commits into from Jun 3, 2020
Merged

fix!: change routing to remove location parameter in preparation for the addition of regional support #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c80c17d
Cloud DLP - fix routing for gRPC clients by embedding location into p…
yoshi-automation May 12, 2020
ff7f0e1
Merge branch 'master' into autosynth-googleapis
chingor13 Jun 3, 2020
b215458
chore: allow breaking changes
chingor13 Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 29 additions & 0 deletions google-cloud-dlp/clirr-ignored-differences.xml
View file
Open in desktop
@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/dlp/v2/DlpServiceClient</className>
<method>* createDeidentifyTemplate(*)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/dlp/v2/DlpServiceClient</className>
<method>* createDlpJob(*)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/dlp/v2/DlpServiceClient</className>
<method>* createInspectTemplate(*)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/dlp/v2/DlpServiceClient</className>
<method>* createJobTrigger(*)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/cloud/dlp/v2/DlpServiceClient</className>
<method>* createStoredInfoType(*)</method>
</difference>
</differences>
899 changes: 88 additions & 811 deletions google-cloud-dlp/src/main/java/com/google/cloud/dlp/v2/DlpServiceClient.java
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions google-cloud-dlp/src/main/java/com/google/cloud/dlp/v2/package-info.java
View file
Open in desktop
Expand Up @@ -34,8 +34,8 @@
* <pre>
* <code>
* try (DlpServiceClient dlpServiceClient = DlpServiceClient.create()) {
* String locationId = "";
* ListInfoTypesResponse response = dlpServiceClient.listInfoTypes(locationId);
* String parent = "";
* ListInfoTypesResponse response = dlpServiceClient.listInfoTypes(parent);
* }
* </code>
* </pre>
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-dlp/src/main/java/com/google/cloud/dlp/v2/stub/GrpcDlpServiceStub.java
View file
Open in desktop
Expand Up @@ -562,7 +562,7 @@ public Map<String, String> extract(ReidentifyContentRequest request) {
@Override
public Map<String, String> extract(ListInfoTypesRequest request) {
ImmutableMap.Builder<String, String> params = ImmutableMap.builder();
params.put("location_id", String.valueOf(request.getLocationId()));
params.put("parent", String.valueOf(request.getParent()));
return params.build();
}
})
Expand Down