Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support to customize gcloud command of LocalDatastoreHelper #137

Merged
merged 8 commits into from Jun 4, 2020
Merged

feat: add support to customize gcloud command of LocalDatastoreHelper #137

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
15587f4
feat: add support to customize gcloud command of local datastore helper
athakor May 21, 2020
8654955
feat: modified the code
athakor May 22, 2020
f49a94c
feat: code reftoring
athakor May 22, 2020
098a97b
feat: update the create method and remove the duplicate constructor
athakor May 25, 2020
0ffd3f2
feat: fix review changes
athakor Jun 2, 2020
d8b9176
feat: fixe the build log with timeout failure
athakor Jun 2, 2020
1ffa1f0
feat: cleanup the tmp dir
athakor Jun 3, 2020
13f7c7f
feat: used the deleteRecursively by making it package private
athakor Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...atastore/src/test/java/com/google/cloud/datastore/testing/ITLocalDatastoreHelperTest.java
View file
Open in desktop
Expand Up @@ -33,6 +33,7 @@
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.concurrent.TimeoutException;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
Expand All @@ -53,6 +54,11 @@ public void setUp() throws IOException {
dataDir = Files.createTempDirectory("gcd");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also add a delete in an @After so we're not leaving lots of directories around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}

@After
public void tearDown() throws IOException {
Files.delete(dataDir);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling Files.delete will fail if it is a directory which is not empty javadoc.

Instead you can use the helper method com.google.cloud.datastore.testing.LocalDatastoreHelper#deleteRecursively by making it package-private.

Copy link
Contributor Author

@athakor athakor Jun 4, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. PTAL

}

@Test
public void testCreate() {
LocalDatastoreHelper helper = LocalDatastoreHelper.create(0.75);
Expand Down Expand Up @@ -111,6 +117,7 @@ public void testCreateWithToBuilder() throws IOException {
assertTrue(actualHelper.isStoreOnDisk());
assertEquals(9091, actualHelper.getPort());
assertEquals(dataDir, actualHelper.getGcdPath());
Files.delete(dataDir);
}

@Test
Expand Down