This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
docs(samples): adds samples from documentation with correct region tags #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datacatalog
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
samples
steffnay
changed the title
averikitsch
reviewed
Nov 30, 2020
samples/snippets/src/main/java/com/example/datacatalog/CreateCustomEntry.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/datacatalog/CreateCustomEntry.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/datacatalog/CreateCustomEntry.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/datacatalog/CreateCustomEntry.java
Outdated
Show resolved
Hide resolved
| .createTagTemplate(createTagTemplateRequest); | ||
| System.out.printf("\nTemplate created with name: %s", createdTagTemplate.getName()); | ||
|
|
||
| TagField sourceValue = |
There was a problem hiding this comment.
Should there be another comment for using the tag template to create a tag?
samples/snippets/src/main/java/com/example/datacatalog/GrantTagTemplateUserRole.java
Outdated
Show resolved
Hide resolved
| .setType(FieldType.newBuilder().setPrimitiveType(PrimitiveType.BOOL).build()) | ||
| .build(); | ||
|
|
||
| TagTemplateField piiTypeField = |
There was a problem hiding this comment.
This is hard to read. Can some of the builders be created outside the parent builder?
| // ------------------------------- | ||
| TagField sourceValue = | ||
| TagField.newBuilder().setStringValue("Copied from tlc_yellow_trips_2017").build(); | ||
| TagField numRowsValue = TagField.newBuilder().setDoubleValue(113496874).build(); |
| createTags(projectId, tagTemplateId); | ||
| } | ||
|
|
||
| public static void createTags(String projectId, String tagTemplateId) { |
There was a problem hiding this comment.
nit: Listing the params here too would be nice.
meredithslota
added
the
do not merge
steffnay
changed the title
|
Ref PR #392 |
…ustomEntry.java Co-authored-by: Averi Kitsch <akitsch@google.com>
…ustomEntry.java Co-authored-by: Averi Kitsch <akitsch@google.com>
…gTemplateUserRole.java Co-authored-by: Averi Kitsch <akitsch@google.com>
|
Samples are added in #392. Hence, closing this duplicate PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds samples from DevSite documentation. Region tags included in added/updates files are correct.
The following additions are needed before merging:
Requested changes are limited to samples in the scope of this PR.
Ideally, another PR will update content and metadata of the other existing samples.
Fixes #369 ☕️