Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

fix: fix conversion for pre-epoch timestamps #160

Merged
merged 3 commits into from Feb 25, 2020

Conversation

chingor13
Copy link
Contributor

Fixes #159

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2020
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #160 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #160      +/-   ##
============================================
+ Coverage     66.54%   66.56%   +0.01%     
- Complexity      370      371       +1     
============================================
  Files            34       34              
  Lines          1877     1881       +4     
  Branches        240      241       +1     
============================================
+ Hits           1249     1252       +3     
- Misses          526      527       +1     
  Partials        102      102
Impacted Files Coverage Δ Complexity Δ
...core/src/main/java/com/google/cloud/Timestamp.java 90.62% <100%> (+0.62%) 25 <2> (+1) ⬆️
.../java/com/google/cloud/testing/CommandWrapper.java 87.87% <0%> (-9.1%) 13% <0%> (ø)
...src/main/java/com/google/cloud/ServiceOptions.java 44.26% <0%> (+0.79%) 33% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc0e6c...b17ac48. Read the comment docs.

@chingor13 chingor13 changed the title test: failing test for parsing a negative timestamp fix: fix conversion for pre-epoch timestamps Feb 19, 2020
@chingor13 chingor13 marked this pull request as ready for review February 19, 2020 21:50
@chingor13 chingor13 requested a review from a team February 19, 2020 21:50
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, haven't we seen this problem before a few months back? maybe in a different project?

@chingor13
Copy link
Contributor Author

also, haven't we seen this problem before a few months back? maybe in a different project?

I think this was something similar: googleapis/google-http-java-client#895

@chingor13 chingor13 merged commit 1f8b6b4 into master Feb 25, 2020
@chingor13 chingor13 deleted the fix-negative-timestamp branch February 25, 2020 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp.of(java.sql.Timestamp) off-by-one on pre-epoch dates
4 participants