Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Missing Java class in 2.4.1 JAR #210

Closed
thesamet opened this issue Aug 27, 2021 · 1 comment · Fixed by #214
Closed

Missing Java class in 2.4.1 JAR #210

thesamet opened this issue Aug 27, 2021 · 1 comment · Fixed by #214
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@thesamet
Copy link

Thanks for fixing the issues in #179 and #134. The newest JAR does not include the Java class files for the proto in google/cloud/common_resources.proto.

thesamet added a commit to scalapb/common-protos that referenced this issue Aug 27, 2021
This re-adds google-common-protos and cloud pubsub with a workaround
for googleapis/java-common-protos#210

See scalapb/ScalaPB#1122
thesamet added a commit to scalapb/common-protos that referenced this issue Aug 27, 2021
This re-adds google-common-protos and cloud pubsub with a workaround
for googleapis/java-common-protos#210

See scalapb/ScalaPB#1122
thesamet added a commit to scalapb/common-protos that referenced this issue Aug 27, 2021
This re-adds google-common-protos and cloud pubsub with a workaround
for googleapis/java-common-protos#210

See scalapb/ScalaPB#1122
@thesamet
Copy link
Author

Note that we are using a workaround to exclude this proto from our build so this is a non-blocker for our use case. However, it would be nice to have the issue resolved upstream so the workaround will not be needed.

@Neenu1995 Neenu1995 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Aug 30, 2021
Neenu1995 added a commit that referenced this issue Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants