New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common-protos for ScalaPB 0.11 #1122
Comments
Hi @Tochemey , thanks for reporting. The release of common-protos for ScalaPB 0.11 is blocked by googleapis/java-common-protos#134 as currently the Scala-Java converters do not compile due to a mismatch between the Java classes and protos shipped with common-protos. |
This is currently blocked due to googleapis/java-common-protos#173 |
@thesamet it seems the blocker has been resolved googleapis/java-common-protos#173. |
This is currently blocked due to googleapis/java-common-protos#179 |
@thesamet it's finally available! https://github.com/googleapis/java-common-protos/releases/tag/v2.4.1 |
Yes. However, it comes with a different inconsistency between the protos and Java code (googleapis/java-common-protos#210). I think that this time the impact is minor enough that we can just exclude this proto from our build and list this as a known issue for ScalaPB/common-protos. |
This re-adds google-common-protos and cloud pubsub with a workaround for googleapis/java-common-protos#210 See scalapb/ScalaPB#1122
This re-adds google-common-protos and cloud pubsub with a workaround for googleapis/java-common-protos#210 See scalapb/ScalaPB#1122
This re-adds google-common-protos and cloud pubsub with a workaround for googleapis/java-common-protos#210 See scalapb/ScalaPB#1122
Released 2.4.1-0 for google-common-protos and 1.96.2-0 for google cloud pubsub. |
@thesamet since this is an important release (finally able to work with Spark 3.1.2, sparksql-scalapb and common-protos) can you update the documentation in https://scalapb.github.io/docs/ ? |
FYI the workaround is not required now - googleapis/java-common-protos#214 |
@Ic3fr0g Updated the docs. Also released 2.5.0 for proto-google-common-protos which indeed doesn't require the workaround. |
Hello @thesamet !
but I get the error:
|
Hi @Visorgood , it looks like your question is unrelated to common-protos (which is the issue you have posted it on). Can you file a new issue, also can you investigate how |
Thank you @thesamet ! You are right, the problem is a different one. I've solved it by adding exclusion for frameless-dataset library in this way:
|
No description provided.
The text was updated successfully, but these errors were encountered: