Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Duplicate proto files in 2.3.0 JAR #173

Closed
thesamet opened this issue May 21, 2021 · 0 comments · Fixed by #176
Closed

Duplicate proto files in 2.3.0 JAR #173

thesamet opened this issue May 21, 2021 · 0 comments · Fixed by #176
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@thesamet
Copy link

thesamet commented May 21, 2021

Continuing issue #134, the protos shipped in version 2.3.0 of the JAR contain many files with duplicate contents. This leads to many protoc errors such as:

google/rpc/context/attribute_context.proto:315:8: "google.rpc.context.AttributeContext.origin" is already defined in file "google/api/attribute_context.proto".

The complete list of duplicate files below:

$ md5sum **/*.proto | sort | uniq -w 32 -D
03f2b48e6dcc0047e8a0b0de8aaf4bfe  google/api/calendar_period.proto
03f2b48e6dcc0047e8a0b0de8aaf4bfe  google/type/calendar_period.proto
04ed76157edf9f7d4cef5392cd1874f5  google/api/datetime.proto
04ed76157edf9f7d4cef5392cd1874f5  google/type/datetime.proto
2147de87cded539609d441cbd1f702b3  google/api/error_details.proto
2147de87cded539609d441cbd1f702b3  google/rpc/error_details.proto
2962a29501ea623d3f9d846e5a1a3956  google/api/interval.proto
2962a29501ea623d3f9d846e5a1a3956  google/type/interval.proto
2bf1966de8ef1fc96cca89499f62212f  google/api/money.proto
2bf1966de8ef1fc96cca89499f62212f  google/type/money.proto
33a9da27328106855e5093a677eebf4f  google/api/code.proto
33a9da27328106855e5093a677eebf4f  google/rpc/code.proto
378373518b99885055e4f2a2e513746f  google/api/postal_address.proto
378373518b99885055e4f2a2e513746f  google/type/postal_address.proto
37b2e651a559ac260b3930ee930925e2  google/api/dayofweek.proto
37b2e651a559ac260b3930ee930925e2  google/type/dayofweek.proto
39751e630a644f775a93164b2105c12a  google/api/date.proto
39751e630a644f775a93164b2105c12a  google/type/date.proto
42002b98bf804b00d1b075db8034fb40  google/api/viewport.proto
42002b98bf804b00d1b075db8034fb40  google/geo/type/viewport.proto
66fd241cb657de6528e7a1c39aab3df8  google/api/operations.proto
66fd241cb657de6528e7a1c39aab3df8  google/longrunning/operations.proto
72ba9c7257ae3141c1bda270a3549e6e  google/api/status.proto
72ba9c7257ae3141c1bda270a3549e6e  google/rpc/status.proto
839536109a0982cbf9c5e08ba8ed24b0  google/api/quaternion.proto
839536109a0982cbf9c5e08ba8ed24b0  google/type/quaternion.proto
90c42d668cafef174de525dd53aaf55a  google/api/phone_number.proto
90c42d668cafef174de525dd53aaf55a  google/type/phone_number.proto
93552662291ea9f58355b528363d0199  google/api/log_severity.proto
93552662291ea9f58355b528363d0199  google/logging/type/log_severity.proto
967539bd33537cd8e7916ad463835c28  google/api/expr.proto
967539bd33537cd8e7916ad463835c28  google/type/expr.proto
a8b3ea0f8175483061baa2ef62c40f8c  google/api/localized_text.proto
a8b3ea0f8175483061baa2ef62c40f8c  google/type/localized_text.proto
a99bbd983df61bff98c6db7897a92248  google/api/latlng.proto
a99bbd983df61bff98c6db7897a92248  google/type/latlng.proto
b5caa12ee7dc6c3af3e8472fb9d8891d  google/api/month.proto
b5caa12ee7dc6c3af3e8472fb9d8891d  google/type/month.proto
cb6c0b039aceedb04d3c4cef2c43a200  google/api/timeofday.proto
cb6c0b039aceedb04d3c4cef2c43a200  google/type/timeofday.proto
d0eefdfd36bbc3a179a0e8afd6ed6b39  google/api/color.proto
d0eefdfd36bbc3a179a0e8afd6ed6b39  google/type/color.proto
d667083aa3bf4528a6211babf7bb1f15  google/api/audit_log.proto
d667083aa3bf4528a6211babf7bb1f15  google/cloud/audit/audit_log.proto
d8208ecab0da23baa7080c146923adac  google/api/fraction.proto
d8208ecab0da23baa7080c146923adac  google/type/fraction.proto
d859d35fd31fdef31dd793bcbc0ff675  google/api/attribute_context.proto
d859d35fd31fdef31dd793bcbc0ff675  google/rpc/context/attribute_context.proto
f8195a8dea5fcf2c2d62ad2abdb80c88  google/api/http_request.proto
f8195a8dea5fcf2c2d62ad2abdb80c88  google/logging/type/http_request.proto
fa8d5f88c202256a928beb66f7448038  google/api/decimal.proto
fa8d5f88c202256a928beb66f7448038  google/type/decimal.proto
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 23, 2021
@Neenu1995 Neenu1995 added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 26, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants