Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI check that ensures all included clients are using compatible google-cloud-shared-dependencies versions #735

Closed
chingor13 opened this issue Jul 21, 2020 · 5 comments
Assignees
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@chingor13
Copy link
Collaborator

It can start as a non-blocking CI check, but it should block any release from going out as any released version of the google-cloud-bom should converge for these dependencies.

If the CI check fails, it should enumerate the clients that need to update their shared-dependencies version.

@chingor13 chingor13 added the type: process A process-related concern. May include testing, release, or the like. label Jul 21, 2020
@stephaniewang526 stephaniewang526 self-assigned this Jul 22, 2020
@stephaniewang526
Copy link
Contributor

@salehsquared

@stephaniewang526
Copy link
Contributor

stephaniewang526 commented Nov 17, 2020

1. Below releases failed -- need to come up with a better plan:
java-monitoring 2.0.8
java-video-intelligence 1.5.5
java-kms 1.40.2
java-memcache 0.2.7
java-recaptchaenterprise 1.0.6
java-container 1.1.2
java-iot 1.1.7
java-billing 1.1.8
java-language 1.101.6
java-texttospeech 1.2.4
java-speech 1.24.7
java-tasks 1.30.8
java-dlp 2.2.2
java-datacatalog 1.0.9

2. Below blocked releases since automergelabel did not work:
googleapis/java-scheduler#277
googleapis/java-redis#260
googleapis/java-pubsub#430
googleapis/java-dialogflow#366 (comment)
googleapis/java-cloudbuild#321 (comment)
googleapis/java-asset#446 (review)
@sofisl

3. Below blocked releases since force-run label did not work:
googleapis/java-trace#339
googleapis/java-containeranalysis#323
@JustinBeckwith

4. Below blocked releases since renovate-bot did not propose shared-dependencies BOM update (manual updates were then needed):
googleapis/java-webrisk#277
googleapis/java-translate#344
@chingor13

5. Misc observations
java-vision v1.110.7 is mis-tagged since it is released as v1.100.7 on sonatype

@JustinBeckwith
Copy link
Contributor

JustinBeckwith commented Nov 17, 2020

For the force-run label, that's specifically owned by the Kokoro team :) I would suggest filing a b/ bug against them. However - in reality, considering the number of times we smash that label, their SLO is probably pretty good. We can't expect 100% reliability in that label.

btw - I love that y'all are doing this kind of analysis (@bcoe very relevant to our interests)

@stephaniewang526
Copy link
Contributor

stephaniewang526 commented Nov 17, 2020

Latest gcb dashboard v0.145.0 shows only two client libraries are not converging (i.e. do not have the latest version of google-cloud-shared-dependencies BOM implemented):

  1. google-cloud-compute (blocked by failing IT)
  2. google-cloud-firestore (blocked by product team @BenWhitehead )

@stephaniewang526
Copy link
Contributor

This is accomplished by #1752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants