Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge-on-Green: sometimes misses pull requests #1159

Closed
chingor13 opened this issue Nov 19, 2020 · 3 comments
Closed

Merge-on-Green: sometimes misses pull requests #1159

chingor13 opened this issue Nov 19, 2020 · 3 comments
Assignees
@sofisl
Labels
bot: merge on green priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

chingor13 commented Nov 19, 2020 •
edited

We've noticed (especially when tagging in bulk) that merge-on-green sometimes misses PRs:

Some examples:
googleapis/java-scheduler#277
googleapis/java-redis#260
googleapis/java-pubsub#430
googleapis/java-dialogflow#366 (comment)
googleapis/java-cloudbuild#321 (comment)
googleapis/java-asset#446 (review)

I suggest we introduce a second cron that looks for issues tagged with the automerge labels and adds them to the db to watch if they are not already watched. This will catch any missed pull request (due to quota or possibly failed webhook delivery)

See more information: googleapis/java-cloud-bom#735
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. bot: merge on green labels Nov 19, 2020
@bcoe bcoe added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 24, 2020
@bcoe
Copy link
Contributor

bcoe commented Nov 24, 2020

Calling this a p2, since there's the workaround of manually landing; but we will work to prioritize this (in less than the 180 days p2 implies).

@chingor13
Copy link
Contributor Author

This is causing a bunch of pain. In the interim, can we change the "eyes" reaction to a separate label like automerge: watching. This would allow us to use the API to find PRs tagged automerge, but not tagged with the automerge: watching label. AFAIK, you cannot query for the reaction.

@sofisl sofisl mentioned this issue Dec 5, 2020
Merged
@chingor13
Copy link
Contributor Author

#1217 should fix this, closing.

@sofisl sofisl mentioned this issue Jan 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sofisl sofisl

Labels
bot: merge on green priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chingor13 @bcoe @sofisl