Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix UpperBoundsDep check for checker-qual #941

Merged
merged 1 commit into from Aug 9, 2021
Merged

deps: fix UpperBoundsDep check for checker-qual #941

merged 1 commit into from Aug 9, 2021

Commits on Aug 9, 2021

  1. dep: fix UpperBoundsDep check for checker-qual 

    googleapis#939 switch guava from -android to -jre, which replaced the transitive dep checker-compat-qual with checker-qual. This introduced a version conflict between guava's transitive deps and truth's: gauva depends on version 3.8.0 while truth depends on 3.13.0. googleapis#939 tried to workaround the conflict by excluding the transitive dep from truth, but it didnt do it all places. This finishes the workaround.

I'm not convinced that this is the correct way to resolve the dependency conflict, but for now this PR just makes it consistent
    @igorbernstein2
    igorbernstein2 committed Aug 9, 2021
    Copy the full SHA
    673b14e View commit details
    Browse the repository at this point in the history