Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix connection pool size for samples #880

Merged
merged 2 commits into from Jun 22, 2021
Merged

docs: fix connection pool size for samples #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ac6b5
docs: fix connection pool size for samples
billyjacobson Jun 22, 2021
f6a3bb6
update test
billyjacobson Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/snippets/src/main/java/com/example/bigtable/ConfigureConnectionPool.java
View file
Open in desktop
Expand Up @@ -37,7 +37,7 @@ public static void configureConnectionPool(String projectId, String instanceId)
settingsBuilder.stubSettings()
.setTransportChannelProvider(
EnhancedBigtableStubSettings.defaultGrpcTransportProviderBuilder()
.setPoolSize(250)
.setPoolSize(10)
.build());

BigtableDataSettings settings = settingsBuilder.build();
Expand Down
2 changes: 1 addition & 1 deletion samples/snippets/src/test/java/com/example/bigtable/ConfigureConnectionPoolTest.java
View file
Open in desktop
Expand Up @@ -41,6 +41,6 @@ public void testConfigureConnectionPool() {
ConfigureConnectionPool.configureConnectionPool(projectId, instanceId);

String output = bout.toString();
assertThat(output, CoreMatchers.containsString("Connected with pool size of 250"));
assertThat(output, CoreMatchers.containsString("Connected with pool size of 10"));
}
}