Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix maven test configs to make sure admin tests don't clobber data tests #47

Merged
merged 2 commits into from Oct 28, 2019
+10 −6
Merged

fix: fix maven test configs to make sure admin tests don't clobber data tests #47

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f686b72
fix: fix maven test configs to make sure admin tests don't clobber da…
igorbernstein2 Oct 28, 2019
85a8160
Update include patterns
igorbernstein2 Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 14 additions & 6 deletions google-cloud-bigtable/pom.xml
View file
Open in desktop
Expand Up @@ -206,8 +206,11 @@
<systemPropertyVariables>
<bigtable.env>emulator</bigtable.env>
</systemPropertyVariables>
<test>com.google.cloud.bigtable.data.v2.it.**</test>
<test>com.google.cloud.bigtable.admin.v2.it.**</test>
<includes>
<include>com.google.cloud.bigtable.data.v2.it.**</include>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to replace this with a one-liner: com.google.cloud.bigtable.**.v2.it.**? Not super familiar with the syntax here but wanted to check!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, updated. Thanks for the suggestion

<include>com.google.cloud.bigtable.admin.v2.it.**</include>
</includes>

<summaryFile>${project.build.directory}/failsafe-reports/failsafe-summary-emulator-it.xml</summaryFile>
</configuration>
</execution>
Expand All @@ -234,8 +237,10 @@
<systemPropertyVariables>
<bigtable.env>prod</bigtable.env>
</systemPropertyVariables>
<test>com.google.cloud.bigtable.data.v2.it.**</test>
<test>com.google.cloud.bigtable.admin.v2.it.**</test>
<includes>
<include>com.google.cloud.bigtable.data.v2.it.**</include>
<include>com.google.cloud.bigtable.admin.v2.it.**</include>
</includes>
<summaryFile>${project.build.directory}/failsafe-reports/failsafe-summary-prod-it.xml</summaryFile>
</configuration>
</execution>
Expand Down Expand Up @@ -268,8 +273,11 @@
<environmentVariables>
<GOOGLE_CLOUD_ENABLE_DIRECT_PATH>bigtable</GOOGLE_CLOUD_ENABLE_DIRECT_PATH>
</environmentVariables>
<!-- TODO(igorbernstein): Once the control plane is accessible via directpath, add admin tests -->
<test>com.google.cloud.bigtable.data.v2.it.**</test>
<includes>
<include>com.google.cloud.bigtable.data.v2.it.**</include>
<!-- TODO(igorbernstein): Once the control plane is accessible via directpath, add admin tests -->
<!-- <include>com.google.cloud.bigtable.admin.v2.it.**</include>-->
</includes>
<summaryFile>${project.build.directory}/failsafe-reports/failsafe-summary-directpath-it.xml</summaryFile>
</configuration>
</execution>
Expand Down