Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle recovery failures during stream reframing failure #46

Merged
merged 3 commits into from Oct 28, 2019
Merged

fix: handle recovery failures during stream reframing failure #46

merged 3 commits into from Oct 28, 2019

Commits on Oct 28, 2019

  1. fix: handle recovery failures during stream reframing failure 

    This was discovered while debugging another issue. While deflaking
ReadRowRetryTest, this issue came up preventing me from seeing the
underlying issue.

ReframingResponseObserver#deliverUnsafe() should never fail. However if
does, it will try to cancel the upstream stream and notify the
downstream observer. However canceling the upstream can throw an
exception and prevent the downstram observer from being notified of any
error.

This fix will catch cancellation errors and add them as suppressed
exceptions to the original failure
    @igorbernstein2
    igorbernstein2 committed Oct 28, 2019
    Copy the full SHA
    5cfb90a View commit details
    Browse the repository at this point in the history

  2. add test

    @igorbernstein2
    igorbernstein2 committed Oct 28, 2019
    Copy the full SHA
    8ae8337 View commit details
    Browse the repository at this point in the history

  3. format

    @igorbernstein2
    igorbernstein2 committed Oct 28, 2019
    Copy the full SHA
    d389a01 View commit details
    Browse the repository at this point in the history