Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change app_profile_id to the correct header app_profile #318

Merged
merged 1 commit into from May 27, 2020
Merged

fix: change app_profile_id to the correct header app_profile #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...d-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java
View file
Open in desktop
Expand Up @@ -303,7 +303,7 @@ private <ReqT, RowT> ServerStreamingCallable<ReadRowsRequest, RowT> createReadRo
public Map<String, String> extract(ReadRowsRequest readRowsRequest) {
return ImmutableMap.of(
"table_name", readRowsRequest.getTableName(),
"app_profile_id", readRowsRequest.getAppProfileId());
"app_profile", readRowsRequest.getAppProfileId());
}
})
.build(),
Expand Down Expand Up @@ -360,7 +360,7 @@ public Map<String, String> extract(
SampleRowKeysRequest sampleRowKeysRequest) {
return ImmutableMap.of(
"table_name", sampleRowKeysRequest.getTableName(),
"app_profile_id", sampleRowKeysRequest.getAppProfileId());
"app_profile", sampleRowKeysRequest.getAppProfileId());
}
})
.build(),
Expand Down Expand Up @@ -394,7 +394,7 @@ private UnaryCallable<RowMutation, Void> createMutateRowCallable() {
public Map<String, String> extract(MutateRowRequest mutateRowRequest) {
return ImmutableMap.of(
"table_name", mutateRowRequest.getTableName(),
"app_profile_id", mutateRowRequest.getAppProfileId());
"app_profile", mutateRowRequest.getAppProfileId());
}
})
.build(),
Expand Down Expand Up @@ -507,7 +507,7 @@ private UnaryCallable<MutateRowsRequest, Void> createMutateRowsBaseCallable() {
public Map<String, String> extract(MutateRowsRequest mutateRowsRequest) {
return ImmutableMap.of(
"table_name", mutateRowsRequest.getTableName(),
"app_profile_id", mutateRowsRequest.getAppProfileId());
"app_profile", mutateRowsRequest.getAppProfileId());
}
})
.build(),
Expand Down Expand Up @@ -549,7 +549,7 @@ public Map<String, String> extract(
CheckAndMutateRowRequest checkAndMutateRowRequest) {
return ImmutableMap.of(
"table_name", checkAndMutateRowRequest.getTableName(),
"app_profile_id", checkAndMutateRowRequest.getAppProfileId());
"app_profile", checkAndMutateRowRequest.getAppProfileId());
}
})
.build(),
Expand Down Expand Up @@ -583,7 +583,7 @@ private UnaryCallable<ReadModifyWriteRow, Row> createReadModifyWriteRowCallable(
public Map<String, String> extract(ReadModifyWriteRowRequest request) {
return ImmutableMap.of(
"table_name", request.getTableName(),
"app_profile_id", request.getAppProfileId());
"app_profile", request.getAppProfileId());
}
})
.build(),
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/HeadersTest.java
View file
Open in desktop
Expand Up @@ -175,7 +175,7 @@ private void verifyHeaderSent() {
String requestParamsvalue = metadata.get(X_GOOG_REQUEST_PARAMS_KEY);
assertThat(requestParamsvalue).containsMatch("(^|.*&)table_name=" + TABLE_NAME + "($|&.*)");
assertThat(requestParamsvalue)
.containsMatch("(^|.*&)app_profile_id=" + APP_PROFILE_ID + "($|&.*)");
.containsMatch("(^|.*&)app_profile=" + APP_PROFILE_ID + "($|&.*)");

String apiClientValue = metadata.get(API_CLIENT_HEADER_KEY);
assertThat(apiClientValue).containsMatch("gl-java/[.\\d_]+");
Expand Down