Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bigtable v2 retry config settings to disable streaming RPC retries #315

Merged
merged 1 commit into from May 27, 2020
Merged

fix: bigtable v2 retry config settings to disable streaming RPC retries #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...d-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableStubSettings.java
View file
Open in desktop
Expand Up @@ -311,13 +311,13 @@ private static Builder initDefaults(Builder builder) {

builder
.readRowsSettings()
.setRetryableCodes(RETRYABLE_CODE_DEFINITIONS.get("idempotent"))
.setRetryableCodes(RETRYABLE_CODE_DEFINITIONS.get("non_idempotent"))
.setRetrySettings(RETRY_PARAM_DEFINITIONS.get("read_rows_params"));

builder
.sampleRowKeysSettings()
.setRetryableCodes(RETRYABLE_CODE_DEFINITIONS.get("idempotent"))
.setRetrySettings(RETRY_PARAM_DEFINITIONS.get("idempotent_params"));
.setRetryableCodes(RETRYABLE_CODE_DEFINITIONS.get("non_idempotent"))
.setRetrySettings(RETRY_PARAM_DEFINITIONS.get("non_idempotent_params"));

builder
.mutateRowSettings()
Expand All @@ -326,7 +326,7 @@ private static Builder initDefaults(Builder builder) {

builder
.mutateRowsSettings()
.setRetryableCodes(RETRYABLE_CODE_DEFINITIONS.get("idempotent"))
.setRetryableCodes(RETRYABLE_CODE_DEFINITIONS.get("non_idempotent"))
.setRetrySettings(RETRY_PARAM_DEFINITIONS.get("mutate_rows_params"));

builder
Expand Down
6 changes: 3 additions & 3 deletions synth.metadata
View file
Open in desktop
Expand Up @@ -4,15 +4,15 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/java-bigtable.git",
"sha": "0ef4959c25ab65d65ae3533455af0e7a351851d3"
"sha": "b17e39f2d8ca84335ab85d80372d6a0309a684c6"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "fb8f62b6784f43faf4b64179c57ce4b4931b1a00",
"internalRef": "310426317"
"sha": "a175708acd7a367ab3ed120fa562331e1761d825",
"internalRef": "312558019"
}
},
{
Expand Down