Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding utility to transform protobuf into model object #299

Merged
merged 5 commits into from May 14, 2020
Merged

feat: adding utility to transform protobuf into model object #299

merged 5 commits into from May 14, 2020

Commits on May 11, 2020

  1. feat: adding utility to transform protobuf into model object 

    With this commit, User shall be able to transform protobuf object to bigtable client's specific model objects.
    @rahulKQL
    rahulKQL committed May 11, 2020
    Copy the full SHA
    ea099c4 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. chore: addressed feedback comments 

     - updated the JavaDoc
 - marked the utility as `@BetaApi`
    @rahulKQL
    rahulKQL committed May 12, 2020
    Copy the full SHA
    154130d View commit details
    Browse the repository at this point in the history

  2. chore: addressed feedback comments 

     - Rephrased Javadoc to include more explanation
 - change `Mutation#fromProto` visibility to package only
    @rahulKQL
    rahulKQL committed May 12, 2020
    Copy the full SHA
    511f924 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. chore: removed VisibleForTesting annotation 

    As Mutation#fromProto is being used by RowMutation#fromProto, So removed `@VisibleForTesting` annotation
    @rahulKQL
    rahulKQL committed May 13, 2020
    Copy the full SHA
    e079eff View commit details
    Browse the repository at this point in the history

  2. chore: extended unit tests to verify project and instance override

    @rahulKQL
    rahulKQL committed May 13, 2020
    Copy the full SHA
    1e680e8 View commit details
    Browse the repository at this point in the history