Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set x-goog-api-client as internal header #293

Merged
merged 2 commits into from May 8, 2020

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented May 8, 2020

No description provided.

@kolea2 kolea2 requested a review from igorbernstein2 May 8, 2020 21:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2020
@kolea2
Copy link
Collaborator Author

kolea2 commented May 8, 2020

@igorbernstein2 updated

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #293 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #293   +/-   ##
=========================================
  Coverage     79.51%   79.51%           
  Complexity      991      991           
=========================================
  Files            99       99           
  Lines          6443     6444    +1     
  Branches        318      318           
=========================================
+ Hits           5123     5124    +1     
  Misses         1119     1119           
  Partials        201      201           
Impacted Files Coverage Δ Complexity Δ
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 95.15% <100.00%> (+0.02%) 20.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea631a...2e68125. Read the comment docs.

@kolea2 kolea2 merged commit 3b58a4f into googleapis:master May 8, 2020
@kolea2 kolea2 deleted the fix-header branch May 8, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants