feat: expose new API with ReadRowsRequest in EnhancedBigtableStub #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leStub This commit would enable the user to target the table using absolute resource name on each read request. Currently we expose `ServerStreamingCallable<Query, RowT>`, which does not have an option to provide different `app-profile-id` on each request.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
============================================
- Coverage 79.72% 79.52% -0.21%
- Complexity 991 992 +1
============================================
Files 99 99
Lines 6388 6447 +59
Branches 319 318 -1
============================================
+ Hits 5093 5127 +34
- Misses 1098 1119 +21
- Partials 197 201 +4
Continue to review full report at Codecov.
|
igorbernstein2
requested changes
May 1, 2020
There was a problem hiding this comment.
This code is a bit hard to follow can we reorg it a bit?
ServerStreamingCallable<ReadRowsRequest,RowT> createBaseCallable(settings, adapter)
- create the base chain with retries and row stitching
ServerStreamingCallable<ReadRowsRequest, RowT> createReadRowsRawCallable(adapter)
- calls baseCallable
- adds Context
createReadRowsCallable(adapter)
- calls baseCallable
- adds ReadRowsUserCallable
- adds tracing + metrics
- adds context
createReadRowsCallable(adapter)
- calls baseCallable
- adds ReadRowsUserCallable
- first()
- adds tracing + metrics
- adds context
| * | ||
| * <p>NOTE: the caller is responsible for adding tracing & metrics. | ||
| */ | ||
| public <RowT> ServerStreamingCallable<ReadRowsRequest, RowT> createReadRowsRawCallable( |
There was a problem hiding this comment.
Please mark this as BetaApi and add a disclaimer that this method might be removed in the future
| * | ||
| * <p>NOTE: the caller is responsible for adding tracing & metrics. | ||
| */ | ||
| public <RowT> ServerStreamingCallable<ReadRowsRequest, RowT> createReadRowsBaseCallable( |
There was a problem hiding this comment.
This should not be public
With this commit, the public createReadRowsCallable() would refer to single createReadRowsBaseCallable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275
This commit would enable the user to target the table using an absolute resource name on each read request. Currently, we expose
ServerStreamingCallable<Query, RowT>, which does not have an option to provide differentapp-profile-idon each request.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: