feat: add toString to Bigtable*Settings to display defaults #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
============================================
- Coverage 80.69% 80.15% -0.54%
Complexity 1049 1049
============================================
Files 99 99
Lines 6541 6556 +15
Branches 344 322 -22
============================================
- Hits 5278 5255 -23
- Misses 1082 1097 +15
- Partials 181 204 +23
Continue to review full report at Codecov.
|
|
I think we can improve on this: The main thing that this is missing is the per-rpc settings: what's the total timeout for readRows? what's exponential backoff is configured for mutateRow? |
igorbernstein2
added
the
needs work
|
@rahulKQL is this unblocked now? |
|
Unfortunately, this still blocked due to #1017 from gax is yet to release. |
stephaniewang526
previously approved these changes
Jun 22, 2020
This PR adds toString() to all three BigtableDataSettings,BigtableTableAdminSettings, BigtableInstanceAdminSettings. This is to help user log the current settings.
kolea2
reviewed
Jul 15, 2020
| public String toString() { | ||
| return MoreObjects.toStringHelper(this) | ||
| .add("projectId", projectId) | ||
| .add("stubSettings", stubSettings) |
There was a problem hiding this comment.
does this need instanceId, or is it part of this?
product-auto-label
bot
added
the
api: bigtable
|
Closing in favor #488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233
This PR adds toString() to all three BigtableDataSettings,BigtableTableAdminSettings, BigtableInstanceAdminSettings. This is to help user log the current settings.
This would display the default in the following manner:
BigtableDataSettings{projectId=fake-project, instanceId=fake-instance, appProfileId=fake-app-profile, stubSettings=EnhancedBigtableStubSettings{executorProvider=InstantiatingExecutorProvider{executorThreadCount=8, threadFactory=com.google.api.gax.core.InstantiatingExecutorProvider$1@533dcfeb}, transportChannelProvider=com.google.api.gax.grpc.InstantiatingGrpcChannelProvider@8062dcc, credentialsProvider=GoogleCredentialsProvider{scopesToApply=[https://www.googleapis.com/auth/bigtable.data, https://www.googleapis.com/auth/bigtable.data.readonly, https://www.googleapis.com/auth/cloud-bigtable.data, https://www.googleapis.com/auth/cloud-bigtable.data.readonly, https://www.googleapis.com/auth/cloud-platform, https://www.googleapis.com/auth/cloud-platform.read-only], jwtEnabledScopes=[https://www.googleapis.com/auth/bigtable.data, https://www.googleapis.com/auth/cloud-bigtable.data, https://www.googleapis.com/auth/cloud-platform], OAuth2Credentials=null}, headerProvider=com.google.api.gax.rpc.NoHeaderProvider@bab4db70, internalHeaderProvider=com.google.api.gax.rpc.NoHeaderProvider@6d584b5d, clock=com.google.api.core.NanoClock@f33616bc, endpoint=bigtable.googleapis.com:443, streamWatchdogProvider=com.google.api.gax.rpc.InstantiatingWatchdogProvider@885d9266, streamWatchdogCheckInterval=PT10S, tracerFactory=com.google.api.gax.tracing.OpencensusTracerFactory@121cd451}}