Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add builtin metrics part 2 #1054

Closed
wants to merge 23 commits into from
Closed

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Nov 1, 2021

Part 2 of adding builtin metrics, add a new package that uses shaded opencensus, with more labels, and reuse the logic in MetricsTracer

TODOs

  • Clean up code
  • Add more tests

@mutianf mutianf requested review from a team as code owners November 1, 2021 16:13
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Nov 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2021
@mutianf mutianf marked this pull request as draft November 1, 2021 16:13
@mutianf mutianf changed the title feat: add builtin metrics part 1 feat: add builtin metrics part 2 Nov 1, 2021
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/PULL_REQUEST_TEMPLATE.md
  • .github/sync-repo-settings.yaml
  • .github/workflows/approve-readme.yaml
  • .github/workflows/auto-release.yaml
  • .github/workflows/ci.yaml
  • .github/workflows/samples.yaml
  • .kokoro/build.bat
  • .kokoro/build.sh
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/gapic_metadata.json
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableStub.java
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableStubSettings.java
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/GrpcBigtableStub.java
  • grpc-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/BigtableGrpc.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/BigtableProto.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/ReadRowsRequest.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/ReadRowsRequestOrBuilder.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/RowFilter.java
  • proto-google-cloud-bigtable-v2/src/main/proto/google/bigtable/v2/bigtable.proto
  • proto-google-cloud-bigtable-v2/src/main/proto/google/bigtable/v2/data.proto
  • samples/install-without-bom/pom.xml
  • samples/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@snippet-bot
Copy link

snippet-bot bot commented Mar 18, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 3, 2022
mutianf and others added 15 commits May 3, 2022 14:50
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) | action | major | `v3` -> `v5` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

### [`v5`](https://togithub.com/actions/github-script/compare/v4...v5)

[Compare Source](https://togithub.com/actions/github-script/compare/v4...v5)

### [`v4`](https://togithub.com/actions/github-script/compare/v3...v4)

[Compare Source](https://togithub.com/actions/github-script/compare/v3...v4)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigtable).
igorbernstein2 and others added 5 commits May 3, 2022 14:50
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) | action | major | `v5` -> `v6` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

### [`v6`](https://togithub.com/actions/github-script/compare/v5...v6)

[Compare Source](https://togithub.com/actions/github-script/compare/v5...v6)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigtable).
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants