Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix typo in rst stream message #1029

Merged
merged 2 commits into from Oct 5, 2021
Merged

fix: fix typo in rst stream message #1029

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f17e61
fix: fix typo in rst stream message
mutianf Oct 5, 2021
80b48a1
filter all errors with "rst stream" in it
mutianf Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ava/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsConvertExceptionCallable.java
View file
Open in desktop
Expand Up @@ -78,7 +78,7 @@ private Throwable convertException(Throwable t) {
// Long lived connections sometimes are disconnected via an RST frame. This error is
// transient and should be retried.
if (t instanceof InternalException) {
if (t.getMessage() != null && t.getMessage().contains("Received Rst stream")) {
if (t.getMessage() != null && t.getMessage().contains("Received Rst Stream")) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we use a case insensitive comparison?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just simplify this to lowercase().contains("rst_stream") || lowercase.contains("rst stream")

return new InternalException(t, ((InternalException) t).getStatusCode(), true);
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...able/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsRetryTest.java
View file
Open in desktop
Expand Up @@ -270,7 +270,7 @@ public void retryRstStreamExceptionTest() {
new InternalException(
new StatusRuntimeException(
Status.INTERNAL.withDescription(
"HTTP/2 error code: INTERNAL_ERROR\nReceived Rst stream")),
"INTERNAL: HTTP/2 error code: INTERNAL_ERROR\nReceived Rst Stream")),
GrpcStatusCode.of(Code.INTERNAL),
false);
service.expectations.add(
Expand Down