Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: client.close() should wait until the channels are terminated bef… #1000

Merged
merged 2 commits into from Sep 10, 2021
Merged

fix: client.close() should wait until the channels are terminated bef… #1000

merged 2 commits into from Sep 10, 2021

Commits on Sep 9, 2021

  1. fix: client.close() should wait until the channels are terminated bef… 

    …ore shutting down the executor (googleapis#916)

* fix: client.close() should wait until the channels are terminated before shutting down the executor

Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor

* copyright

(cherry picked from commit 914f0cc)
    @igorbernstein2 @kolea2
    igorbernstein2 authored and kolea2 committed Sep 9, 2021
    Copy the full SHA
    0ee85a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Merge branch '1.22.0-sp' of github.com:googleapis/java-bigtable into … 

    …port-916
    @kolea2
    kolea2 committed Sep 10, 2021
    Copy the full SHA
    f19d687 View commit details
    Browse the repository at this point in the history