fix: improve embedded version handling (#715) #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: improve embedded version handling Use new feature in releasetool (googleapis/releasetool#317) to manage the client version instead of maven tricks introduced in googleapis#451 * migrate to new version scheme * rename back to Version * config release-please for version bumps * make sure file doesnt get clobbered * add a couple of tests * fmt (cherry picked from commit 1af8925)
product-auto-label
bot
added
the
api: bigtable
|
Warning: This pull request is touching the following templated files:
|
google-cla
bot
added
the
cla: yes
(cherry picked from commit f914954)
igorbernstein2
approved these changes
May 21, 2021
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/VersionTest.java
Outdated
Show resolved
Hide resolved
igorbernstein2
requested changes
May 21, 2021
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/VersionTest.java
Outdated
Show resolved
Hide resolved
igorbernstein2
approved these changes
May 21, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 24, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.22.0-sp.1](https://www.github.com/googleapis/java-bigtable/compare/1.22.0...v1.22.0-sp.1) (2021-05-21) ### Features * configure initial sp version ([#829](https://www.github.com/googleapis/java-bigtable/issues/829)) ([47480c5](https://www.github.com/googleapis/java-bigtable/commit/47480c55ab08b80154a4a7d2bb76a9dccfcdea03)) ### Bug Fixes * filter limit constant ([#787](https://www.github.com/googleapis/java-bigtable/issues/787)) ([#835](https://www.github.com/googleapis/java-bigtable/issues/835)) ([cf16cfe](https://www.github.com/googleapis/java-bigtable/commit/cf16cfe5ee1ec509ed8faf3ff1342bd02a041468)) * improve embedded version handling ([#715](https://www.github.com/googleapis/java-bigtable/issues/715)) ([#832](https://www.github.com/googleapis/java-bigtable/issues/832)) ([f0fc1bf](https://www.github.com/googleapis/java-bigtable/commit/f0fc1bf77962ddc80bfd5aca6a8ca731641d940b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 1af8925)
additional fixing version cherry pick: (cherry picked from commit f914954)