Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add status label to gfe metrics #1077

Merged
merged 1 commit into from Dec 1, 2021
Merged

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Nov 19, 2021

Refactor BigtableTracer and HeaderTracer callables to include status in the label and add Status label to the GFE metric views.

@mutianf mutianf requested a review from a team as a code owner November 19, 2021 15:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Nov 19, 2021
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mutianf mutianf merged commit 777549e into googleapis:main Dec 1, 2021
@mutianf mutianf deleted the refactor branch December 1, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants