make the test more readable

googleapis · Dec 9, 2021 · aae1b35 · aae1b35
1 parent 9cb143a
commit aae1b35
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/...gtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/RpcViewConstants.java b/...gtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/RpcViewConstants.java
@@ -156,6 +156,7 @@ class RpcViewConstants {
               BIGTABLE_OP,
               BIGTABLE_STATUS));
 
+  // use distribution so we can correlate batch throttled time with op_latency
   static final View BIGTABLE_BATCH_THROTTLED_TIME_VIEW =
       View.create(
           View.Name.create("cloud.google.com/java/bigtable/batch_throttled_time"),

diff --git a/...oud-bigtable/src/test/java/com/google/cloud/bigtable/misc_utilities/MethodComparator.java b/...oud-bigtable/src/test/java/com/google/cloud/bigtable/misc_utilities/MethodComparator.java
@@ -31,12 +31,9 @@ public class MethodComparator {
           MethodComparator::compareMethods, "compare method names, parameters and return types");
 
   private static boolean compareMethods(Method actual, Method expected) {
-    if (!actual.getName().equals(expected.getName())
-        || !Arrays.equals(actual.getParameterTypes(), expected.getParameterTypes())
-        || actual.getModifiers() != expected.getModifiers()
-        || !actual.getReturnType().equals(expected.getReturnType())) {
-      return false;
-    }
-    return true;
+    return actual.getName().equals(expected.getName())
+        && Arrays.equals(actual.getParameterTypes(), expected.getParameterTypes())
+        && actual.getModifiers() == expected.getModifiers()
+        && actual.getReturnType().equals(expected.getReturnType());
   }
 }