Skip to content

Commit

Permalink
chore: update build cfgs (#393)
Browse files Browse the repository at this point in the history
* chore(java_templates): add lint/static analysis presubmit checks for samples

* chore(java_templates): add lint/static analysis presubmit checks for samples

* chore: fix trailing whitespace

Source-Author: Jeff Ching <chingor@google.com>
Source-Date: Mon Aug 17 14:29:16 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: c3caf0704f25a0c365f1c315e804a30b87c62a75
Source-Link: googleapis/synthtool@c3caf07

* chore(java_templates): stop running pmd/spotbugs checks for samples

This was creating too much noise. We will revisit with other options and/or tune these checks.

Source-Author: Jeff Ching <chingor@google.com>
Source-Date: Wed Aug 19 12:26:49 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 9602086c6c5b05db77950c7f7495a2a3868f3537
Source-Link: googleapis/synthtool@9602086
  • Loading branch information
yoshi-automation committed Aug 20, 2020
1 parent f9bf950 commit 667a21d
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
14 changes: 14 additions & 0 deletions .github/workflows/samples.yaml
@@ -0,0 +1,14 @@
on:
pull_request:
name: samples
jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v1
with:
java-version: 8
- name: Run checkstyle
run: mvn -P lint --quiet --batch-mode checkstyle:check
working-directory: samples/snippets
7 changes: 3 additions & 4 deletions synth.metadata
Expand Up @@ -4,7 +4,7 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/java-bigtable.git",
"sha": "37c38bd34405e0f4fc4b08f2a43f614bb869309e"
"sha": "f9bf950a91a9264d539c5a8ad22e74a7fa3dc722"
}
},
{
Expand All @@ -19,7 +19,7 @@
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "f8823dec98277a9516f2fb6fae9f58b3a59a23e1"
"sha": "9602086c6c5b05db77950c7f7495a2a3868f3537"
}
}
],
Expand Down Expand Up @@ -51,6 +51,7 @@
".github/release-please.yml",
".github/trusted-contribution.yml",
".github/workflows/ci.yaml",
".github/workflows/samples.yaml",
".kokoro/build.bat",
".kokoro/build.sh",
".kokoro/coerce_logs.sh",
Expand All @@ -66,7 +67,6 @@
".kokoro/nightly/java8-osx.cfg",
".kokoro/nightly/java8-win.cfg",
".kokoro/nightly/java8.cfg",
".kokoro/nightly/samples.cfg",
".kokoro/populate-secrets.sh",
".kokoro/presubmit/clirr.cfg",
".kokoro/presubmit/common.cfg",
Expand All @@ -78,7 +78,6 @@
".kokoro/presubmit/java8.cfg",
".kokoro/presubmit/linkage-monitor.cfg",
".kokoro/presubmit/lint.cfg",
".kokoro/presubmit/samples.cfg",
".kokoro/release/bump_snapshot.cfg",
".kokoro/release/common.cfg",
".kokoro/release/common.sh",
Expand Down

0 comments on commit 667a21d

Please sign in to comment.