fix: fix typo in rst stream message (#1029)

* fix: fix typo in rst stream message * filter all errors with "rst stream" in it
googleapis · Oct 5, 2021 · 50e6860 · 50e6860
1 parent 0bb3754
commit 50e6860
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...ava/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsConvertExceptionCallable.java b/...ava/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsConvertExceptionCallable.java
@@ -77,8 +77,9 @@ public void onComplete() {
   private Throwable convertException(Throwable t) {
     // Long lived connections sometimes are disconnected via an RST frame. This error is
     // transient and should be retried.
-    if (t instanceof InternalException) {
-      if (t.getMessage() != null && t.getMessage().contains("Received Rst stream")) {
+    if (t instanceof InternalException && t.getMessage() != null) {
+      String error = t.getMessage().toLowerCase();
+      if (error.contains("rst_stream") || error.contains("rst stream")) {
         return new InternalException(t, ((InternalException) t).getStatusCode(), true);
       }
     }

diff --git a/...able/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsRetryTest.java b/...able/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsRetryTest.java
@@ -270,7 +270,7 @@ public void retryRstStreamExceptionTest() {
         new InternalException(
             new StatusRuntimeException(
                 Status.INTERNAL.withDescription(
-                    "HTTP/2 error code: INTERNAL_ERROR\nReceived Rst stream")),
+                    "INTERNAL: HTTP/2 error code: INTERNAL_ERROR\nReceived Rst Stream")),
             GrpcStatusCode.of(Code.INTERNAL),
             false);
     service.expectations.add(