Skip to content

Commit 4614912

Browse files
revert: Revert "feat: promote stream wait timeouts to deadlines for point reads" (#876)
Reverts #848
1 parent 50c0a51 commit 4614912

File tree

4 files changed

+8
-277
lines changed

4 files changed

+8
-277
lines changed

google-cloud-bigtable/clirr-ignored-differences.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,9 @@
2323
<differenceType>8001</differenceType>
2424
<className>com/google/cloud/bigtable/gaxx/tracing/WrappedTracerFactory*</className>
2525
</difference>
26-
</differences>
26+
<!-- InternalApi that was removed -->
27+
<difference>
28+
<differenceType>8001</differenceType>
29+
<className>com/google/cloud/bigtable/data/v2/stub/readrows/PointReadTimeoutCallable</className>
30+
</difference>
31+
</differences>

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@
7575
import com.google.cloud.bigtable.data.v2.stub.mutaterows.MutateRowsBatchingDescriptor;
7676
import com.google.cloud.bigtable.data.v2.stub.mutaterows.MutateRowsRetryingCallable;
7777
import com.google.cloud.bigtable.data.v2.stub.readrows.FilterMarkerRowsCallable;
78-
import com.google.cloud.bigtable.data.v2.stub.readrows.PointReadTimeoutCallable;
7978
import com.google.cloud.bigtable.data.v2.stub.readrows.ReadRowsBatchingDescriptor;
8079
import com.google.cloud.bigtable.data.v2.stub.readrows.ReadRowsConvertExceptionCallable;
8180
import com.google.cloud.bigtable.data.v2.stub.readrows.ReadRowsResumptionStrategy;
@@ -337,7 +336,7 @@ public <RowT> UnaryCallable<Query, RowT> createReadRowCallable(RowAdapter<RowT>
337336
private <ReqT, RowT> ServerStreamingCallable<ReadRowsRequest, RowT> createReadRowsBaseCallable(
338337
ServerStreamingCallSettings<ReqT, Row> readRowsSettings, RowAdapter<RowT> rowAdapter) {
339338

340-
final ServerStreamingCallable<ReadRowsRequest, ReadRowsResponse> base =
339+
ServerStreamingCallable<ReadRowsRequest, ReadRowsResponse> base =
341340
GrpcRawCallableFactory.createServerStreamingCallable(
342341
GrpcCallSettings.<ReadRowsRequest, ReadRowsResponse>newBuilder()
343342
.setMethodDescriptor(BigtableGrpc.getReadRowsMethod())
@@ -353,15 +352,11 @@ public Map<String, String> extract(ReadRowsRequest readRowsRequest) {
353352
.build(),
354353
readRowsSettings.getRetryableCodes());
355354

356-
// Promote streamWaitTimeout to deadline for point reads
357-
ServerStreamingCallable<ReadRowsRequest, ReadRowsResponse> withPointTimeouts =
358-
new PointReadTimeoutCallable<>(base);
359-
360355
// Sometimes ReadRows connections are disconnected via an RST frame. This error is transient and
361356
// should be treated similar to UNAVAILABLE. However, this exception has an INTERNAL error code
362357
// which by default is not retryable. Convert the exception so it can be retried in the client.
363358
ServerStreamingCallable<ReadRowsRequest, ReadRowsResponse> convertException =
364-
new ReadRowsConvertExceptionCallable<>(withPointTimeouts);
359+
new ReadRowsConvertExceptionCallable<>(base);
365360

366361
ServerStreamingCallable<ReadRowsRequest, RowT> merging =
367362
new RowMergingCallable<>(convertException, rowAdapter);

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/readrows/PointReadTimeoutCallable.java

Lines changed: 0 additions & 86 deletions
This file was deleted.

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/PointReadTimeoutCallableTest.java

Lines changed: 0 additions & 183 deletions
This file was deleted.

0 commit comments

Comments
 (0)