feat: Add support for renaming tables in schema translator #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#3154) Remove any column family transformations and reduce the transoformer to support table names only. We don't want to encourage column family renames as there are many implications of column family renames. Mainly, 1. read filters won't work as they involve regexes 2. Migration validation jobs won't work as the column families will be different and hashes won't match. There are complex ways to solve these issues but we can't see use-cases for column family renames that justify making this migration workflow complex around creation, querying and validation. (cherry picked from commit 7d49bba)
product-auto-label
bot
added
the
api: bigtable
google-cla
bot
added
the
cla: yes
vermas2012
added
kokoro:run
yoshi-kokoro
removed
the
kokoro:force-run
kolea2
reviewed
Aug 10, 2021
...ase-1.x-tools/src/main/java/com/google/cloud/bigtable/hbase/tools/HBaseSchemaTranslator.java
Outdated
Show resolved
Hide resolved
vermas2012
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
igorbernstein2
requested changes
Aug 13, 2021
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kolea2
approved these changes
Aug 17, 2021
...ase-1.x-tools/src/main/java/com/google/cloud/bigtable/hbase/tools/HBaseSchemaTranslator.java
Outdated
Show resolved
Hide resolved
...ase-1.x-tools/src/main/java/com/google/cloud/bigtable/hbase/tools/HBaseSchemaTranslator.java
Outdated
Show resolved
Hide resolved
vermas2012
added
the
automerge
4 tasks
vermas2012
requested review from
kolea2 and
igorbernstein2
and removed request for
igorbernstein2
igorbernstein2
approved these changes
Aug 19, 2021
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 19, 2021
Bringing changes done to bigtable-1.x in #3185 to master. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bu g/issue](https://github.com/googleapis/java-bigtable-hbase/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.24.0](https://www.github.com/googleapis/java-bigtable-hbase/compare/v1.23.1...v1.24.0) (2021-08-31) ### Features * Add support for renaming tables in schema translator ([#3185](https://www.github.com/googleapis/java-bigtable-hbase/issues/3185)) ([e294c1e](https://www.github.com/googleapis/java-bigtable-hbase/commit/e294c1ecd9a985558e8447cf2fa954040016a23a)) * log bulk mutation entry errors ([#3198](https://www.github.com/googleapis/java-bigtable-hbase/issues/3198)) ([0618ddb](https://www.github.com/googleapis/java-bigtable-hbase/commit/0618ddb6a323c3d795658a306721751502329fcd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mutianf
pushed a commit
to mutianf/java-bigtable-hbase
that referenced
this pull request
Sep 20, 2022
…s#3185) * feat: Add support for renaming tables in schema translator (googleapis#3154) Remove any column family transformations and reduce the transoformer to support table names only. We don't want to encourage column family renames as there are many implications of column family renames. Mainly, 1. read filters won't work as they involve regexes 2. Migration validation jobs won't work as the column families will be different and hashes won't match. There are complex ways to solve these issues but we can't see use-cases for column family renames that justify making this migration workflow complex around creation, querying and validation. (cherry picked from commit 7d49bba) * Fix javax.annotation build issues. * Fix version number in the comments * Fix the bad merge. * Incorporating PR feedback
mutianf
pushed a commit
to mutianf/java-bigtable-hbase
that referenced
this pull request
Sep 20, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.24.0](https://www.github.com/googleapis/java-bigtable-hbase/compare/v1.23.1...v1.24.0) (2021-08-31) ### Features * Add support for renaming tables in schema translator ([googleapis#3185](https://www.github.com/googleapis/java-bigtable-hbase/issues/3185)) ([e294c1e](https://www.github.com/googleapis/java-bigtable-hbase/commit/e294c1ecd9a985558e8447cf2fa954040016a23a)) * log bulk mutation entry errors ([googleapis#3198](https://www.github.com/googleapis/java-bigtable-hbase/issues/3198)) ([0618ddb](https://www.github.com/googleapis/java-bigtable-hbase/commit/0618ddb6a323c3d795658a306721751502329fcd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bigtable-1.x merge for PR #3154
#3154