New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: E2E test for time encoding #941
test: E2E test for time encoding #941
Conversation
…d in a different PR
…omplex-schema test(Java): Jstocklass stress testing complex schema
… table insertion holds up
ddc7eb0
to
6bc03d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
- There are IT failures: https://source.cloud.google.com/results/invocations/a6ec1f57-d8d3-4ad4-8574-146b4604c560/targets ptal.
- This branch is not up-to-date against
master
. Please check out master,git pull
. check out this branch,git merge
-- resolve any merge conflict if needed and thengit push
.
This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-03-18 22:45:20,095 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-bigquerystorage/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-03-18 22:45:21,018 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/93099bcc-ab35-48d5-ab7a-79fbfbcb0bba/targets - [ ] To automatically regenerate this PR, check this box.
This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-03-22 15:32:14,816 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-bigquerystorage/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-03-22 15:32:15,852 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/9be4b08c-65bc-4ddb-81cf-9402bf4f1a1b/targets - [ ] To automatically regenerate this PR, check this box.
…Stocklass/java-bigquerystorage into jstocklass-time-encode-e2e
…Stocklass/java-bigquerystorage into jstocklass-time-encode-e2e
@stephaniewang526 I've taken care of the IT errors for the time being and I'm not sure why the integration test is failing to build. It appears that files in the proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/ are having a hard time finding symbols. I'm not sure if that is related to the changes made here. I've also rebased the branch against master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but please cleanup the extra diffs. It seems your branch is somehow newer than the current master?
...test/java/com/google/cloud/bigquery/storage/v1alpha2/BQTableSchemaToProtoDescriptorTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make sure to cleanup extra diffs.
assertEquals("23:59:59.999999", currentRow.get(1).getRepeatedValue().get(1).getStringValue()); | ||
assertEquals("00:00:00", currentRow.get(1).getRepeatedValue().get(2).getStringValue()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to verify: Is the precision difference here deterministic? Or could these tests fail later due to a precision change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is deterministic. The time is checked that truncating to micros is equivalent to it's original time so it should return an intentional illegal argument if the precision change were to cause a problem.
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️