Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: testAppendWhileShutdownSuccess race #907

Merged
merged 3 commits into from Mar 3, 2021
Merged

fix: testAppendWhileShutdownSuccess race #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bd755c
fix:testAppendWhileShutdownSuccess race
yirutang Mar 3, 2021
568fe7b
.
yirutang Mar 3, 2021
f9aa2aa
.
yirutang Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriter.java
View file
Open in desktop
Expand Up @@ -924,7 +924,7 @@ public void onResponse(AppendRowsResponse response) {
IllegalStateException exception =
new IllegalStateException(
String.format(
"The append result offset %s does not match " + "the expected offset %s.",
"The append result offset %s does not match the expected offset %s.",
response.getAppendResult().getOffset().getValue(),
inflightBatch.getExpectedOffset()));
inflightBatch.onFailure(exception);
Expand Down
2 changes: 2 additions & 0 deletions ...uerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterTest.java
View file
Open in desktop
Expand Up @@ -678,6 +678,7 @@ public void testAppendWhileShutdownSuccess() throws Exception {
.toBuilder()
// When shutdown, we should have something in batch.
.setElementCountThreshold(3L)
.setDelayThreshold(Duration.ofSeconds(1000))
.setFlowControlSettings(
StreamWriter.Builder.DEFAULT_FLOW_CONTROL_SETTINGS
.toBuilder()
Expand Down Expand Up @@ -1072,6 +1073,7 @@ public void testOffset() throws Exception {
StreamWriter.Builder.DEFAULT_BATCHING_SETTINGS
.toBuilder()
.setElementCountThreshold(2L)
.setDelayThreshold(Duration.ofSeconds(1000))
.build())
.build()) {

Expand Down