Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove apache commons lang #585

Merged
merged 1 commit into from Oct 2, 2020
Merged

fix: remove apache commons lang #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions google-cloud-bigquerystorage/pom.xml
View file
Open in desktop
Expand Up @@ -104,10 +104,6 @@
<groupId>org.threeten</groupId>
<artifactId>threetenbp</artifactId>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
</dependency>
<dependency>
<groupId>org.json</groupId>
<artifactId>json</artifactId>
Expand Down
6 changes: 3 additions & 3 deletions ...erystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@
import com.google.api.gax.rpc.DataLossException;
import com.google.cloud.bigquery.storage.test.Test.FooType;
import com.google.cloud.bigquery.storage.v1alpha2.Storage.*;
import com.google.common.base.Strings;
import com.google.protobuf.DescriptorProtos;
import com.google.protobuf.Int64Value;
import com.google.protobuf.Timestamp;
Expand All @@ -47,7 +48,6 @@
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
import java.util.logging.Logger;
import org.apache.commons.lang3.StringUtils;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
Expand Down Expand Up @@ -262,9 +262,9 @@ public void testAppendByNumBytes() throws Exception {
assertEquals(1L, appendFuture2.get().getOffset());
assertFalse(appendFuture3.isDone());

// This message is big enough to trigger send on the pervious message and itself.
// This message is big enough to trigger send on the previous message and itself.
ApiFuture<AppendRowsResponse> appendFuture4 =
sendTestMessage(writer, new String[] {StringUtils.repeat('A', 100)});
sendTestMessage(writer, new String[] {Strings.repeat("A", 100)});
assertEquals(2L, appendFuture3.get().getOffset());
assertEquals(3L, appendFuture4.get().getOffset());

Expand Down
6 changes: 0 additions & 6 deletions pom.xml
View file
Open in desktop
Expand Up @@ -65,7 +65,6 @@
<github.global.server>github</github.global.server>
<site.installationModule>google-cloud-bigquerystorage-parent</site.installationModule>
<jackson-core.version>2.11.3</jackson-core.version>
<commons-lang3.version>3.5</commons-lang3.version>
</properties>

<pluginRepositories>
Expand Down Expand Up @@ -150,11 +149,6 @@
<artifactId>jackson-core</artifactId>
<version>${jackson-core.version}</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>${commons-lang3.version}</version>
</dependency>
<dependency>
<groupId>org.json</groupId>
<artifactId>json</artifactId>
Expand Down
1 change: 0 additions & 1 deletion renovate.json
View file
Open in desktop
Expand Up @@ -76,7 +76,6 @@
"groupName": "jackson dependencies"
}
],
"ignoreDeps": ["org.apache.commons:commons-lang3"],
"semanticCommits": true,
"masterIssue": true
}