Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump dependency versions #53

Merged
merged 1 commit into from Feb 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions google-cloud-bigquerystorage/pom.xml
Expand Up @@ -105,7 +105,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-bigquery</artifactId>
<version>1.102.0</version>
<version>1.106.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely the upgrade that's causing the issues. I'd try splitting this out into a separate PR to isolate it.

</dependency>
<dependency>
<groupId>com.google.code.findbugs</groupId>
Expand All @@ -119,7 +119,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-core</artifactId>
<version>1.92.3</version>
<version>${google.core.version}</version>
</dependency>

<dependency>
Expand Down
18 changes: 15 additions & 3 deletions pom.xml
Expand Up @@ -63,12 +63,14 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<github.global.server>github</github.global.server>
<site.installationModule>google-cloud-bigquerystorage-parent</site.installationModule>
<google.core.version>1.91.1</google.core.version>
<google.core.version>1.92.4</google.core.version>
<google.api-common.version>1.8.1</google.api-common.version>
<google.common-protos.version>1.17.0</google.common-protos.version>
<gax.version>1.53.0</gax.version>
<gax.version>1.53.1</gax.version>
<auto-value-annotations.version>1.7</auto-value-annotations.version>
<jackson-core.version>2.10.2</jackson-core.version>
<grpc.version>1.27.0</grpc.version>
<protobuf.version>3.11.1</protobuf.version>
<protobuf.version>3.11.3</protobuf.version>
<junit.version>4.13</junit.version>
<guava.version>28.2-android</guava.version>
<threeten.version>1.4.1</threeten.version>
Expand Down Expand Up @@ -108,6 +110,16 @@
<artifactId>grpc-google-cloud-bigquerystorage-v1beta2</artifactId>
<version>0.85.2-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-bigquerystorage-v1beta2:current} -->
</dependency>
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to add these two. Just move avro to the end of your dependencies section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe not. The avro dependency on jackson is not as deep.

<groupId>com.google.auto.value</groupId>
<artifactId>auto-value-annotations</artifactId>
<version>${auto-value-annotations.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${jackson-core.version}</version>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-bigquerystorage</artifactId>
Expand Down