Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BQ Numeric is compatible with double and float protobuf types #367

Merged
merged 2 commits into from Jun 22, 2020
Merged

fix: BQ Numeric is compatible with double and float protobuf types #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44bc140
Fixed BQ numeric bug: BQ Numeric is compatible with doubles and floats
allenc3 Jun 22, 2020
c0cf3b1
Fix linting
allenc3 Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...storage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/SchemaCompatibility.java
View file
Open in desktop
Expand Up @@ -206,6 +206,11 @@ private static boolean isCompatibleWithBQNumeric(Descriptors.FieldDescriptor.Typ
return true;
}

if (field == Descriptors.FieldDescriptor.Type.FLOAT
|| field == Descriptors.FieldDescriptor.Type.DOUBLE) {
return true;
}

return false;
}

Expand Down
4 changes: 3 additions & 1 deletion ...age/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/SchemaCompatibilityTest.java
View file
Open in desktop
Expand Up @@ -729,7 +729,9 @@ public void testBQNumeric() {
Fixed64Type.getDescriptor(),
SFixed32Type.getDescriptor(),
SFixed64Type.getDescriptor(),
BytesType.getDescriptor()));
BytesType.getDescriptor(),
FloatType.getDescriptor(),
DoubleType.getDescriptor()));

for (Descriptors.Descriptor descriptor : type_descriptors) {
if (compatible.contains(descriptor)) {
Expand Down