Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more writeapi manual client test issues #241

Merged
merged 2 commits into from May 4, 2020
Merged

fix: more writeapi manual client test issues #241

merged 2 commits into from May 4, 2020

Commits on May 1, 2020

  1. fix: more test issues 

    - Fix some unwanted exceptions in the test run by make sure writers are cleaned up.
- Fix another executor race issue.
- The reconnection test failure is wired, it seems the test was shut down while running. I split the tests into 3 and reduce its run length. It could be due to testing taking too long to run (each wait is 7 seconds and there were 4 waits).

	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriterCache.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/WriterCacheTest.java
    @yirutang
    yirutang committed May 1, 2020
    Copy the full SHA
    2c8da9d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. remove some unhonored retry setting checks

    @yirutang
    yirutang committed May 4, 2020
    Copy the full SHA
    ad9d8c6 View commit details
    Browse the repository at this point in the history