Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: several StreamWriter issues #213

Merged
merged 3 commits into from Apr 24, 2020
Merged

fix: several StreamWriter issues #213

merged 3 commits into from Apr 24, 2020

Commits on Apr 23, 2020

  1. fix: several StreamWriter issues 

    - Make messages wait in flow controll to be delivered in order
- Avoid recreating the BigQueryWriteClient stub during reconnection, which is not necessary.
- Allow user to pass in BigQueryWriteClient stub so that it can be shared with other API calls.

	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/Waiter.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
    @yirutang
    yirutang committed Apr 23, 2020
    Copy the full SHA
    c094264 View commit details
    Browse the repository at this point in the history

  2. Wait doesn't need to be synchronized

    @yirutang
    yirutang committed Apr 23, 2020
    Copy the full SHA
    cff1439 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. fix: unlock is not called in exception case 

    	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/Waiter.java
    @yirutang
    yirutang committed Apr 24, 2020
    Copy the full SHA
    32b1f7c View commit details
    Browse the repository at this point in the history