Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BQ/proto schema names should be compared lowercase #1369

Merged
merged 10 commits into from Oct 25, 2021
Merged

fix: BQ/proto schema names should be compared lowercase #1369

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
374160b
fix: BQ/proto schema names should be compared lowercase
stephenjudkins Oct 19, 2021
7e602d9
fix: add test for mixed-cased field name
stephenjudkins Oct 20, 2021
c51017a
fix: add test to v1beta2 as well
stephenjudkins Oct 20, 2021
f53df7f
format
stephenjudkins Oct 20, 2021
f18710c
🦉 Updates from OwlBot
gcf-owl-bot[bot] Oct 25, 2021
2385a33
🦉 Updates from OwlBot
gcf-owl-bot[bot] Oct 25, 2021
0de4e75
Merge branch 'sdj/1366/fix-mixed-case-fieldnames' of https://github.c…
gcf-owl-bot[bot] Oct 25, 2021
1c93511
Update JsonToProtoMessageTest.java
stephaniewang526 Oct 25, 2021
2eba5ea
Update dependencies.sh
stephaniewang526 Oct 25, 2021
c6de143
Update dependencies.sh
stephaniewang526 Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...igquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessage.java
View file
Open in desktop
Expand Up @@ -124,7 +124,7 @@ private static DynamicMessage convertJsonToProtoMessageImpl(
if (tableSchema != null) {
// protoSchema is generated from tableSchema so their field ordering should match.
fieldSchema = tableSchema.get(field.getIndex());
if (!fieldSchema.getName().equals(field.getName())) {
if (!fieldSchema.getName().toLowerCase().equals(field.getName())) {
throw new ValidationException(
"Field at index "
+ field.getIndex()
Expand Down
2 changes: 1 addition & 1 deletion ...rystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/JsonToProtoMessage.java
View file
Open in desktop
Expand Up @@ -123,7 +123,7 @@ private static DynamicMessage convertJsonToProtoMessageImpl(
if (tableSchema != null) {
// protoSchema is generated from tableSchema so their field ordering should match.
fieldSchema = tableSchema.get(field.getIndex());
if (!fieldSchema.getName().equals(field.getName())) {
if (!fieldSchema.getName().toLowerCase().equals(field.getName())) {
throw new ValidationException(
"Field at index "
+ field.getIndex()
Expand Down