refactor(samples): updates params and comments (#543)

googleapis · Nov 30, 2020 · a9e8e97 · a9e8e97
1 parent 69a2965
commit a9e8e97
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 10 deletions.
diff --git a/samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreateAdManagerTransfer.java b/samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreateAdManagerTransfer.java
@@ -36,7 +36,8 @@ public static void main(String[] args) throws IOException {
     final String projectId = "MY_PROJECT_ID";
     String datasetId = "MY_DATASET_ID";
     String bucket = "gs://cloud-sample-data";
-    String networkCode = "MY_NETWORK_CODE";
+    // the network_code can only be digits with length 1 to 15
+    String networkCode = "12345678";
     Map<String, Value> params = new HashMap<>();
     params.put("bucket", Value.newBuilder().setStringValue(bucket).build());
     params.put("network_code", Value.newBuilder().setStringValue(networkCode).build());
@@ -46,7 +47,6 @@ public static void main(String[] args) throws IOException {
             .setDisplayName("Your Ad Manager Config Name")
             .setDataSourceId("dfp_dt")
             .setParams(Struct.newBuilder().putAllFields(params).build())
-            .setSchedule("every 24 hours")
             .build();
     createAdManagerTransfer(projectId, transferConfig);
   }

diff --git a/samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreateAdsTransfer.java b/samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreateAdsTransfer.java
@@ -35,8 +35,9 @@ public static void main(String[] args) throws IOException {
     // TODO(developer): Replace these variables before running the sample.
     final String projectId = "MY_PROJECT_ID";
     String datasetId = "MY_DATASET_ID";
-    String customerId = "MY_CUSTOMER_ID";
-    String refreshWindow = "MY_REFRESH_WINDOW";
+    // the customer_id only allows digits and hyphen ('-').
+    String customerId = "012-345-6789";
+    String refreshWindow = "100";
     Map<String, Value> params = new HashMap<>();
     params.put("customer_id", Value.newBuilder().setStringValue(customerId).build());
     params.put("refreshWindow", Value.newBuilder().setStringValue(refreshWindow).build());
@@ -46,7 +47,6 @@ public static void main(String[] args) throws IOException {
             .setDisplayName("Your Ads Transfer Config Name")
             .setDataSourceId("adwords")
             .setParams(Struct.newBuilder().putAllFields(params).build())
-            .setSchedule("every 24 hours")
             .build();
     createAdsTransfer(projectId, transferConfig);
   }

diff --git a/...nippets/src/main/java/com/example/bigquerydatatransfer/CreateCampaignmanagerTransfer.java b/...nippets/src/main/java/com/example/bigquerydatatransfer/CreateCampaignmanagerTransfer.java
@@ -36,7 +36,8 @@ public static void main(String[] args) throws IOException {
     final String projectId = "MY_PROJECT_ID";
     String datasetId = "MY_DATASET_ID";
     String bucket = "gs://cloud-sample-data";
-    String networkId = "MY_DOUBLE_CLICK_ID";
+    // the network_id only allows digits
+    String networkId = "7878";
     String fileNamePrefix = "test_";
     Map<String, Value> params = new HashMap<>();
     params.put("bucket", Value.newBuilder().setStringValue(bucket).build());
@@ -48,7 +49,6 @@ public static void main(String[] args) throws IOException {
             .setDisplayName("Your Campaignmanager Config Name")
             .setDataSourceId("dcm_dt")
             .setParams(Struct.newBuilder().putAllFields(params).build())
-            .setSchedule("every 24 hours")
             .build();
     createCampaignmanagerTransfer(projectId, transferConfig);
   }

diff --git a/samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreatePlayTransfer.java b/samples/snippets/src/main/java/com/example/bigquerydatatransfer/CreatePlayTransfer.java
@@ -46,7 +46,6 @@ public static void main(String[] args) throws IOException {
             .setDisplayName("Your Play Config Name")
             .setDataSourceId("play")
             .setParams(Struct.newBuilder().putAllFields(params).build())
-            .setSchedule("every 24 hours")
             .build();
     createPlayTransfer(projectId, transferConfig);
   }

diff --git a/...snippets/src/main/java/com/example/bigquerydatatransfer/CreateYoutubeChannelTransfer.java b/...snippets/src/main/java/com/example/bigquerydatatransfer/CreateYoutubeChannelTransfer.java
@@ -44,7 +44,6 @@ public static void main(String[] args) throws IOException {
             .setDisplayName("Your Youtube Channel Config Name")
             .setDataSourceId("youtube_channel")
             .setParams(Struct.newBuilder().putAllFields(params).build())
-            .setSchedule("every 24 hours")
             .build();
     createYoutubeChannelTransfer(projectId, transferConfig);
   }

diff --git a/...ets/src/main/java/com/example/bigquerydatatransfer/CreateYoutubeContentOwnerTransfer.java b/...ets/src/main/java/com/example/bigquerydatatransfer/CreateYoutubeContentOwnerTransfer.java
@@ -46,7 +46,6 @@ public static void main(String[] args) throws IOException {
             .setDisplayName("Your Youtube Owner Channel Config Name")
             .setDataSourceId("youtube_content_owner")
             .setParams(Struct.newBuilder().putAllFields(params).build())
-            .setSchedule("every 24 hours")
             .build();
     createYoutubeContentOwnerTransfer(projectId, transferConfig);
   }