Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

sample: remove AwsCrossAccountRole from AWS sample. #850

Merged
merged 2 commits into from Jun 7, 2023

Conversation

TAnchor
Copy link
Contributor

@TAnchor TAnchor commented Jun 7, 2023

fix: remove AwsCrossAccountRole from AWS sample.

This was updated in https://github.com/googleapis/java-bigqueryconnection/pull/576/files, but one reference to AwsCrossAccountRole was not changed, which causes the sample to not work as the cross account role is no longer supported.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

This was updated in https://github.com/googleapis/java-bigqueryconnection/pull/576/files, but one reference to AwsCrossAccountRole was not changed, which causes the sample to not work as the cross account role is no longer supported.
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigqueryconnection Issues related to the googleapis/java-bigqueryconnection API. samples Issues that are directly related to samples. labels Jun 7, 2023
@Neenu1995 Neenu1995 changed the title Remove AwsCrossAccountRole from AWS sample. sample: remove AwsCrossAccountRole from AWS sample. Jun 7, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@Neenu1995 Neenu1995 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 7, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2023
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 7, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 7, 2023 19:13
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8e15770 into googleapis:main Jun 7, 2023
19 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: bigqueryconnection Issues related to the googleapis/java-bigqueryconnection API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
4 participants