Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove autovalue profile as it has moved to shared-config #370

Merged
merged 2 commits into from May 21, 2020
Merged

feat: remove autovalue profile as it has moved to shared-config #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b6a820
feat: remove autovalue profile as it has moved to shared-config
stephaniewang526 May 19, 2020
9c83994
add enable file to enable profile based on module
stephaniewang526 May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Empty file added google-cloud-bigquery/EnableAutoValue.txt
View file
Open in desktop
Empty file.
84 changes: 1 addition & 83 deletions pom.xml
View file
Open in desktop
Expand Up @@ -67,9 +67,6 @@
<javax.annotations.version>1.3.2</javax.annotations.version>
<google-api-services-bigquery.version>v2-rev20200429-1.30.9
</google-api-services-bigquery.version>
<auto-value.version>1.7.2</auto-value.version>
<auto-value-annotations.version>${auto-value.version}</auto-value-annotations.version>
<auto-service-annotations.version>1.0-rc7</auto-service-annotations.version>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -195,99 +192,20 @@
<link>https://developers.google.com/protocol-buffers/docs/reference/java/</link>
<link>https://googleapis.dev/java/google-auth-library/latest/</link>
<link>https://googleapis.dev/java/gax/latest/</link>
<link>https://googleapis.github.io/api-common-java/${google.api-common.version}/apidocs/</link>
<link>https://googleapis.github.io/api-common-java/</link>
</links>
</configuration>
</plugin>
</plugins>
</reporting>

<profiles>
<profile>
<id>autovalue-java7</id>
<activation>
<jdk>1.7</jdk>
</activation>
<properties>
<auto-value-annotations.version>1.7</auto-value-annotations.version>
<auto-value.version>1.4</auto-value.version>
</properties>
<build>
<plugins>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<annotationProcessorPaths>
<path>
<groupId>com.google.auto.value</groupId>
<artifactId>auto-value</artifactId>
<version>${auto-value.version}</version>
</path>
<!--
There is currently no available version of auto-service-annotations
in maven central compiled for java 1.7 so we can't include it here.

If you're using IntelliJ please use a newer jdk and set the language
level to 1.7 for your dev work.
-->
</annotationProcessorPaths>
</configuration>
</plugin>
</plugins>
</build>
</profile>

<profile>
<id>autovalue-java8</id>
<activation>
<jdk>[1.8,)</jdk>
</activation>
<build>
<plugins>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<annotationProcessorPaths>
<path>
<groupId>com.google.auto.value</groupId>
<artifactId>auto-value</artifactId>
<version>${auto-value.version}</version>
</path>
<!--
Manually pull in auto-service-annotations so that it is part of the
processor path because auto-value has it set to provided scope.

This dependency is needed due to the retention change in
https://github.com/google/auto/commit/628df548685b4fc0f2a9af856f97cc2a68da246b
where the RetentionPolicy changed from SOURCE to CLASS.

Due to the RetentionPolicy change to CLASS we must have the
annotations available on the processor path otherwise the following
will error will be thrown. (This is a particular problem with the
annotation processor configuration in IntelliJ)

Error:java: java.lang.NoClassDefFoundError: com/google/auto/service/AutoService
com.google.auto.service.AutoService
-->
<path>
<groupId>com.google.auto.service</groupId>
<artifactId>auto-service-annotations</artifactId>
<version>${auto-service-annotations.version}</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
</plugins>
</build>
</profile>

<profile>
<id>include-samples</id>
<modules>
<module>samples</module>
</modules>
</profile>

</profiles>

</project>