Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Dataset property maxTimeTravelHours #3015

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brendangreenley
Copy link
Contributor

Adds support for setting and getting the BigQuery v2 API Dataset property maxTimeTravelHours, allowing end users to set the default time travel length for a given dataset. Exposing this flag will allow smarter values to be set for staging datasets which are deleted shortly after creation, which can be costly if a user has pursued a physical billing model for their project/organization.

I used a Long since the googleapis/google-api-java-client-services implementation uses a Long.

@brendangreenley brendangreenley requested review from a team as code owners November 27, 2023 18:26
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 27, 2023
Copy link

conventional-commit-lint-gcf bot commented Nov 27, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Nov 27, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@brendangreenley
Copy link
Contributor Author

@mrfaizal please let me know if there's anything I can do to help get this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants