Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent jobPb.getConfiguration() to throw a NPE #2241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AzemaBaptiste
Copy link

@AzemaBaptiste AzemaBaptiste commented Aug 19, 2022

Fixes #186 ☕️

An NullPointerException is throw when we run a bigquery.listJobs() with a service account using the permission bigquery.jobs.list. If the permission is set to bigquery.jobs.listAll, no NPE is thrown.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@AzemaBaptiste AzemaBaptiste requested review from a team and prash-mi August 19, 2022 14:41
@google-cla
Copy link

google-cla bot commented Aug 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Aug 19, 2022
@AzemaBaptiste
Copy link
Author

Hello @prash-mi, I see you are marked as an reviewer for this PR.
I will be glad if you can have a look, this bug is pretty annoying.
Thanks!

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 1, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@prash-mi prash-mi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2022
@prash-mi
Copy link
Contributor

prash-mi commented Sep 8, 2022

Running the presubmits

@AzemaBaptiste
Copy link
Author

Up @prash-mi is there something blocking here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery.listJobs is throwing NPE
3 participants